View Issue Details

IDProjectCategoryView StatusLast Update
0006939Talerexchangepublic2024-01-12 13:05
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006939: TALER_JSON_spec_amount should have build-in currency compatibility check
DescriptionInstead of forcing the application logic to always check if the currency is acceptable, we should pass the desired currency into the function (NULL could be passed for "do not care" in case the client supports multiple currencies or does their own check). This way, we can remove a lot of duplicate currency validation logic and also avoid a common failure mode of forgetting to check the currency.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

has duplicate 0006934 closedChristian Grothoff add expected currency to JSON spec parser 

Activities

Christian Grothoff

2021-07-24 07:04

manager   ~0018011

Implemented in exchange, currently breaks the merchant build.

Christian Grothoff

2021-07-24 07:17

manager   ~0018012

Implemented in merchant. Still breaks Anastasis build.

Christian Grothoff

2021-07-24 08:03

manager   ~0018013

Implemented.

Christian Grothoff

2021-09-02 16:14

manager   ~0018225

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2021-07-23 11:19Christian GrothoffNew Issue
2021-07-23 11:19Christian GrothoffStatusnew => assigned
2021-07-23 11:19Christian GrothoffAssigned To => Christian Grothoff
2021-07-23 12:24Christian GrothoffRelationship addedhas duplicate 0006934
2021-07-24 07:04Christian GrothoffNote Added: 0018011
2021-07-24 07:17Christian GrothoffNote Added: 0018012
2021-07-24 08:03Christian GrothoffStatusassigned => informing
2021-07-24 08:03Christian GrothoffResolutionopen => fixed
2021-07-24 08:03Christian GrothoffFixed in Version => 0.9
2021-07-24 08:03Christian GrothoffNote Added: 0018013
2021-07-24 08:03Christian GrothoffTarget Version0.9.1 => 0.9
2021-07-30 11:57Christian GrothoffFixed in Version0.9 => 0.8.1
2021-07-30 11:59Christian GrothoffTarget Version0.9 => 0.8.1
2021-07-30 12:01Christian GrothoffFixed in Version0.8.1 => 0.8
2021-07-30 12:02Christian GrothoffTarget Version0.8.1 => 0.8
2021-08-24 14:22Christian GrothoffStatusinforming => closed
2021-09-02 16:13Christian Grothoff
2021-09-02 16:14Christian GrothoffNote Added: 0018225
2024-01-12 13:05Christian GrothoffCategoryexchange API (C) => exchange