View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006859 | Taler | merchant backend | public | 2021-05-10 14:47 | 2021-08-01 13:09 |
| Reporter | sebasjm | Assigned To | sebasjm | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | won't fix | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0006859: add fullfil url into the default configuration of the instance | ||||
| Description | currently there is no fulfillment url when creating an instance a merchant can have it instance configured with a default url that redirect to the merchant instance website after paying (or a thankyou page) order may still override the value when creating the order. also, url should be absolute and always start with https since it will be automatically redirected from the wallet. | ||||
| Tags | No tags attached. | ||||
| I do not think this is what we want: (1) the fulfillment URLs tend to be highly personalized to the order, so a default makes little sense, and (2) they do not have to start with http/https, IIRC taler:// was also possible to show a message inside of the wallet. | |
| This seems to not be documented (?), but we changed this a while ago: 1. Fulfillment URLs should always be http(s) 2. *Instead* of a fulfillment URL, a fulfillment_message can also be shown. We made this change because (2) allows i18n via the fulfillment_message_i18n property, whereas i18n would be difficult with a taler://fulfillment-success URL. | |
| Ah, I see. Well, it should be documented then. Still, I think having a per-instance default is not warranted, wdyt? | |
| I've added documentation for the field to the contract terms specification in the merchant API reference. I don't see the need for a per-instance default, especially since this is very easy to specify for storefronts (no crypto / parsing / etc. necessary). But the UI should allow specifying either the message or URL. | |
| Just to clarify: by UI, you mean the _order creation_ UI in the SPA, right? | |
| Roger that, the UI does allow setting the fulfillment url (and will allow add the messsage) but its optional. Are we ok to make this required? I see rather unnecessary if the message is always "thanks for buying" and a default url may look something like https://acme.com/success/{ORDER_ID}. | |
| I think the fulfillment URL _must_ be optional because it has implications for repurchase detection. Right, Florian? | |
| Yes. It must be optional, or alternatively contain some random ID. Otherwise, the repurchase detection logic might prevent users from completing a purchase. | |
| ACK So, if there is not message nor url the wallet today is showing a message "Redirecting..." but no redirecting because there is no contractTerms.fulfillment_url in the response. Should we add a default message for this case? | |
| Yes. Instead of "redirecting ...", we should show the fulfillment_message, or a default message if no fulfillment_message is specified. (Generally either fulfillment_url or fulfillment_message should be specified though.) | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-05-10 14:47 | sebasjm | New Issue | |
| 2021-05-10 14:47 | sebasjm | Status | new => assigned |
| 2021-05-10 14:47 | sebasjm | Assigned To | => Christian Grothoff |
| 2021-05-11 10:25 | Christian Grothoff | Note Added: 0017818 | |
| 2021-05-11 10:30 | Florian Dold | Note Added: 0017819 | |
| 2021-05-11 10:33 | Christian Grothoff | Note Added: 0017821 | |
| 2021-05-11 10:42 | Florian Dold | Note Added: 0017822 | |
| 2021-05-11 10:57 | Christian Grothoff | Note Added: 0017824 | |
| 2021-05-11 16:23 | sebasjm | Note Added: 0017829 | |
| 2021-05-11 20:55 | Christian Grothoff | Note Added: 0017837 | |
| 2021-05-11 20:55 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2021-05-11 20:56 | Christian Grothoff | Status | assigned => feedback |
| 2021-05-12 12:56 | Florian Dold | Note Added: 0017842 | |
| 2021-05-12 12:56 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2021-05-12 13:50 | sebasjm | Note Added: 0017843 | |
| 2021-05-12 14:17 | Florian Dold | Note Added: 0017844 | |
| 2021-08-01 13:09 | Christian Grothoff | Reproducibility | have not tried => N/A |
| 2021-08-01 13:09 | Christian Grothoff | Status | feedback => closed |
| 2021-08-01 13:09 | Christian Grothoff | Resolution | open => won't fix |
| 2021-08-01 13:09 | Christian Grothoff | Fixed in Version | => 0.8 |
| 2021-08-01 13:09 | Christian Grothoff | Target Version | git (master) => 0.8 |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |