View Issue Details

IDProjectCategoryView StatusLast Update
0006839Talerexchangepublic2021-08-24 14:23
Reportersebasjm Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006839: cannot build exchange
DescriptionIm trying to build anastasis, for that I was working in the build process of the exchange but failed when running make

taler_error_codes.c:26:10: fatal error: gettext.h: No such file or directory
   26 | #include <gettext.h>

I saw that gana was updated here

https://git.gnunet.org/gana.git/commit/?id=df4206c1dc3481faa2e15d497036632229ac9071

gettext is installed and gettext.h is in the filesystem
But found strange that ./configure didnt check for this.

I can work around meanwhile

export CFLAGS="-I/usr/share/gettext"
Additional Information#cat /etc/issue
Debian GNU/Linux bullseye/sid
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2021-04-08 21:59

manager   ~0017714

We don't check for it because gettext.h should be in exchange.git/src/include/gettext.h -- so the system version should NOT be needed. But maybe the INCLUDE path in the Makefile is wrong? Let me investigate.

Christian Grothoff

2021-04-08 22:02

manager   ~0017715

I just removed my system's gettext, and the build worked fine. Do you really have the latest Git with src/include/gettext.h present?

sebasjm

2021-04-08 22:23

developer   ~0017716

I didnt have the latest version of the exchange.
Now I have the gettext.h in the repository so I expect this to work without the workaround as you mention.

But, an older version of the exchange is not going to build with this gana version and the exchange is always going to download the latest gana from git?

sebasjm

2021-04-08 22:32

developer   ~0017717

Yes, build process worked as expected.

Maybe the gana.sh script should not pull the latest version from master but to use the version referenced by the commit submodule.
If the exchange needs a newer version it can push a different "Subproject commit" after the gana repository was updated.

Christian Grothoff

2021-04-09 14:36

manager   ~0017721

I am not sure how the version pulled by the gana.sh script relates to anything here. Anyway, what I do think is that
the bootstrap script should not update Gana to master, that should be done by a manual invocation of contrib/gana.sh.

So I have changed this so that bootstrap only updates the submodules, and updating to the latest gana requires manually calling gana.sh.

Christian Grothoff

2021-04-09 14:38

manager   ~0017722

All good now?

sebasjm

2021-04-09 14:54

developer   ~0017724

sed 's/gana.sh/bootstrap/' -i last_comment

> So I have changed this so that bootstrap only updates the submodules, and updating to the latest gana requires manually calling gana.sh.
Yes, this is what I meant. Bootstrap should not pull remote master

> All good now?
Yes, thanks

Issue History

Date ModifiedUsernameFieldChange
2021-04-08 19:17sebasjmNew Issue
2021-04-08 19:17sebasjmStatusnew => assigned
2021-04-08 19:17sebasjmAssigned To => Christian Grothoff
2021-04-08 21:59Christian GrothoffNote Added: 0017714
2021-04-08 22:02Christian GrothoffNote Added: 0017715
2021-04-08 22:02Christian GrothoffStatusassigned => feedback
2021-04-08 22:02Christian GrothoffTarget Versiongit (master) => 0.9
2021-04-08 22:23sebasjmNote Added: 0017716
2021-04-08 22:23sebasjmStatusfeedback => assigned
2021-04-08 22:32sebasjmNote Added: 0017717
2021-04-09 14:36Christian GrothoffNote Added: 0017721
2021-04-09 14:38Christian GrothoffAssigned ToChristian Grothoff => sebasjm
2021-04-09 14:38Christian GrothoffStatusassigned => feedback
2021-04-09 14:38Christian GrothoffNote Added: 0017722
2021-04-09 14:54sebasjmNote Added: 0017724
2021-04-09 14:55sebasjmStatusfeedback => informing
2021-04-09 14:55sebasjmResolutionopen => fixed
2021-07-30 11:56Christian GrothoffFixed in Version => 0.8
2021-07-30 11:59Christian GrothoffTarget Version0.9 => 0.8.1
2021-07-30 12:02Christian GrothoffTarget Version0.8.1 => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed