View Issue Details

IDProjectCategoryView StatusLast Update
0006778Talermerchant backendpublic2021-09-02 16:23
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006778: merchant-lib and testing support for authentication unclear
DescriptionCurrently the merchant lib does not have any explicit support for setting and changing authentication headers. There is GNUNET_CURL_append_header, but that does not seem to allow *removing* a header. Do we want to manage authentication through this, or should the merchant lib functions take some extra context parameter for authentication?

The same concern applies the the merchant's testing lib, which currently can't easily set/remove the authentication header.

TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0006779 closedChristian Grothoff merchant-lib does not support changing instance authentication 

Activities

Christian Grothoff

2021-03-02 22:40

manager   ~0017582

The preferred method is:
 /* initialize HTTP client */
  ctx = GNUNET_CURL_init (&GNUNET_CURL_gnunet_scheduler_reschedule,
                          &rc);
  rc = GNUNET_CURL_gnunet_rc_create (ctx);
  /* setup authorization */
  GNUNET_assert (GNUNET_OK ==
                 GNUNET_CURL_append_header (ctx,
                                            authorization));

Note that if you must change the headers (i.e. different Authorization), you should create a fresh ctx/rc each time.

Christian Grothoff

2021-04-17 17:38

manager   ~0017754

4087bfb..657d5ba adds a command to test 0006779 (posting to /private/auth).

Christian Grothoff

2021-04-17 18:08

manager   ~0017756

da25913e..0453ef45 adds a command (to taler_testing_lib) to add/update/remove an authorization header from the CURL context.

Christian Grothoff

2021-04-17 19:49

manager   ~0017757

657d5ba..08d7955 adds tests and minor bugfixes. Resolving this issue.

Christian Grothoff

2021-09-02 16:23

manager   ~0018350

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2021-03-02 19:53Florian DoldNew Issue
2021-03-02 19:53Florian DoldStatusnew => assigned
2021-03-02 19:53Florian DoldAssigned To => Christian Grothoff
2021-03-02 22:40Christian GrothoffNote Added: 0017582
2021-03-02 22:40Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2021-04-16 21:10Christian GrothoffAssigned ToFlorian Dold => Christian Grothoff
2021-04-17 17:38Christian GrothoffNote Added: 0017754
2021-04-17 17:38Christian GrothoffRelationship addedrelated to 0006779
2021-04-17 18:08Christian GrothoffNote Added: 0017756
2021-04-17 19:49Christian GrothoffNote Added: 0017757
2021-04-17 19:49Christian GrothoffStatusassigned => informing
2021-04-17 19:49Christian GrothoffResolutionopen => fixed
2021-04-17 19:49Christian GrothoffFixed in Version => 0.9
2021-04-17 19:49Christian GrothoffTarget Version => 0.9
2021-07-30 11:57Christian GrothoffFixed in Version0.9 => 0.8.1
2021-07-30 11:59Christian GrothoffTarget Version0.9 => 0.8.1
2021-07-30 12:01Christian GrothoffFixed in Version0.8.1 => 0.8
2021-07-30 12:02Christian GrothoffTarget Version0.8.1 => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2021-09-02 16:22Christian Grothoff
2021-09-02 16:23Christian GrothoffNote Added: 0018350
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend