View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006762 | Taler | merchant backend | public | 2021-02-19 20:41 | 2024-01-12 13:04 |
| Reporter | sebasjm | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0006762: sending an empty string in payto array make the merchant crash | ||||
| Description | sending an empty string in payto array make the merchant crash | ||||
| Steps To Reproduce | curl -q https://backend.demo.taler.net/private/instances/VmoPyCOWycbc74K1 -H 'Authorization: ApiKey sandbox' -X PATCH --data-raw '{"default_wire_transfer_delay":{"d_ms":2000},"default_pay_delay":{"d_ms":1000},"jurisdiction":{},"address":{},"default_wire_fee_amortization":10,"default_max_wire_fee":"KUDOS:2","default_max_deposit_fee":"KUDOS:1","payto_uris":[""],"name":"qwe"}' | ||||
| Additional Information | The errors tells that an assert fails at taler-merchant-httpd_private-patch-instances-ID:307 so adding that check into the next if could be a solution. GNUNET_assert (NULL != wm->j_wire); wm->wire_method = TALER_payto_get_method (ad.payto_uri); - GNUNET_assert (NULL != wm->wire_method); /* This also tests for things like the IBAN being malformed */ - if (GNUNET_OK != + if (NULL == wm->wire_method || GNUNET_OK != TALER_JSON_merchant_wire_signature_hash (wm->j_wire, &wm->h_wire)) { | ||||
| Tags | No tags attached. | ||||
| Attached Files | script-crash.sh (1,047 bytes)
#/bin/bash
ID=$(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w 16 | head -n 1)
echo create instance with id $ID
HOST=https://backend.demo.taler.net
AUTH="ApiKey sandbox"
CURRENCY=KUDOS
#HOST=http://localhost:9966
#AUTH="Bearer secret-token:super_secret"
#CURRENCY=COL
set -x
curl -q $HOST/private/instances -H "Authorization: $AUTH" --data-raw '{"default_wire_transfer_delay":{"d_ms":2000},"default_pay_delay":{"d_ms":1000},"jurisdiction":{},"address":{},"default_wire_fee_amortization":10,"default_max_wire_fee":"'$CURRENCY':2","default_max_deposit_fee":"'$CURRENCY':1","payto_uris":[],"name":"qwe","id":"'$ID'"}'
curl -q $HOST/private/instances/$ID -H "Authorization: $AUTH" | jq '.accounts'
curl -q $HOST/private/instances/$ID -H "Authorization: $AUTH" -X PATCH --data-raw '{"default_wire_transfer_delay":{"d_ms":2000},"default_pay_delay":{"d_ms":1000},"jurisdiction":{},"address":{},"default_wire_fee_amortization":10,"default_max_wire_fee":"'$CURRENCY':2","default_max_deposit_fee":"'$CURRENCY':1","payto_uris":[""],"name":"qwe"}'
| ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-02-19 20:41 | sebasjm | New Issue | |
| 2021-02-19 20:41 | sebasjm | Status | new => assigned |
| 2021-02-19 20:41 | sebasjm | Assigned To | => Christian Grothoff |
| 2021-02-19 20:41 | sebasjm | File Added: script-crash.sh | |
| 2021-02-19 23:30 | Christian Grothoff | Note Added: 0017557 | |
| 2021-02-19 23:30 | Christian Grothoff | Status | assigned => informing |
| 2021-02-19 23:30 | Christian Grothoff | Resolution | open => fixed |
| 2021-02-19 23:30 | Christian Grothoff | Fixed in Version | => 0.9 |
| 2021-02-19 23:30 | Christian Grothoff | Target Version | => 0.9 |
| 2021-02-19 23:30 | Christian Grothoff | Steps to Reproduce Updated | |
| 2021-02-19 23:30 | Christian Grothoff | Additional Information Updated | |
| 2021-07-30 11:57 | Christian Grothoff | Fixed in Version | 0.9 => 0.8.1 |
| 2021-07-30 11:59 | Christian Grothoff | Target Version | 0.9 => 0.8.1 |
| 2021-07-30 12:02 | Christian Grothoff | Fixed in Version | 0.8.1 => 0.8 |
| 2021-07-30 12:02 | Christian Grothoff | Target Version | 0.8.1 => 0.8 |
| 2021-08-24 14:23 | Christian Grothoff | Status | informing => closed |
| 2021-09-02 16:22 | Christian Grothoff | ||
| 2021-09-02 16:23 | Christian Grothoff | Note Added: 0018359 | |
| 2024-01-12 13:04 | Christian Grothoff | Category | merchant backend API (C) => mechant backend |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |