View Issue Details

IDProjectCategoryView StatusLast Update
0006677Talerspecificationpublic2021-09-02 16:23
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006677: consider not using 4xx status code when exchange gives 5xx
DescriptionThe merchant currently returns a 424 status code when the exchange reports some transient error, typically a DB conflict.

The status code 424 is a rather specific WebDAV status code, and the merchant should return something in the range of 5xx, as the error here is clearly not the *client*'s responsibility.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2021-01-07 08:50

manager   ~0017320

I think this was placed in the wrong category. Re-assigning.

Christian Grothoff

2021-01-07 20:00

manager   ~0017329

There were two places in the merchant code with HTTP status 424. One was already spec'ed in GANA to be 502, the other in GANA to be 400. I've fixed both, and also adjusted the handling in libtalermerchant (for two other 424s, which already could no longer be generated). api-merchant.rst already never specified 424.

Christian Grothoff

2021-09-02 16:23

manager   ~0018365

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2021-01-06 15:32Florian DoldNew Issue
2021-01-06 15:32Florian DoldStatusnew => assigned
2021-01-06 15:32Florian DoldAssigned To => grote
2021-01-07 08:50Christian GrothoffNote Added: 0017320
2021-01-07 08:50Christian GrothoffAssigned Togrote => Christian Grothoff
2021-01-07 08:51Christian GrothoffCategorycashier (Android App) => merchant backend API (HTTP specification)
2021-01-07 08:51Christian GrothoffProduct Version => git (master)
2021-01-07 08:51Christian GrothoffTarget Version => 0.8.1
2021-01-07 20:00Christian GrothoffStatusassigned => informing
2021-01-07 20:00Christian GrothoffResolutionopen => fixed
2021-01-07 20:00Christian GrothoffFixed in Version => 0.9
2021-01-07 20:00Christian GrothoffNote Added: 0017329
2021-01-07 20:00Christian GrothoffFixed in Version0.9 => 0.8.1
2021-07-30 12:02Christian GrothoffFixed in Version0.8.1 => 0.8
2021-07-30 12:02Christian GrothoffTarget Version0.8.1 => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2021-09-02 16:22Christian Grothoff
2021-09-02 16:23Christian GrothoffNote Added: 0018365
2024-01-12 13:02Christian GrothoffCategorymerchant backend API (HTTP specification) => specification