View Issue Details

IDProjectCategoryView StatusLast Update
0006619Talerobsolete componentpublic2021-08-24 14:23
ReporterFlorian Dold Assigned ToMS Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityurgentSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006619: bank APIs should return response with 'Access-Control-Allow-Origin: *' header
Description... otherwise browser wallets will have a hard time accessing those APIs.

In particular, error messages from the API should also include this header. Thus the error handling middleware has to be potentially adjusted as well.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

MS

2020-10-08 12:56

reporter   ~0017002

Fixed here: 7d3fc76b7e18c228add147a4cf954aaa6dd31a36.

Florian Dold

2020-10-08 13:16

manager   ~0017003

Reopening until the header is only applied to *API* responses. Applying this to all response (also the one for browsers, where we use cookie auth) would be a security issue.

Christian Grothoff

2020-10-22 10:08

manager   ~0017035

MS: can you please prioritize this? Or do you need more info?

MS

2020-11-02 17:00

reporter   ~0017083

This was addressed a while ago. Requesting feedback from wallet makers.

Florian Dold

2020-11-16 15:24

manager   ~0017144

Looks good to me now.

Issue History

Date ModifiedUsernameFieldChange
2020-10-07 13:01Florian DoldNew Issue
2020-10-07 13:01Florian DoldStatusnew => assigned
2020-10-07 13:01Florian DoldAssigned To => MS
2020-10-08 12:56MSNote Added: 0017002
2020-10-08 12:56MSStatusassigned => informing
2020-10-08 12:56MSResolutionopen => fixed
2020-10-08 13:16Florian DoldStatusinforming => assigned
2020-10-08 13:16Florian DoldNote Added: 0017003
2020-10-11 18:57Christian GrothoffPrioritynormal => urgent
2020-10-11 18:57Christian GrothoffSeverityminor => major
2020-10-22 10:08Christian GrothoffNote Added: 0017035
2020-10-31 09:31Christian GrothoffProduct Version => git (master)
2020-11-02 17:00MSStatusassigned => feedback
2020-11-02 17:00MSNote Added: 0017083
2020-11-16 15:24Florian DoldStatusfeedback => informing
2020-11-16 15:24Florian DoldNote Added: 0017144
2021-07-30 11:57Christian GrothoffFixed in Version => 0.8
2021-07-30 12:02Christian GrothoffTarget Version0.8.1 => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component