View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006600 | Taler | merchant backend | public | 2020-09-10 17:52 | 2021-08-24 14:23 |
| Reporter | MS | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0006600: Refund should not be offered when the frontend did not give a delay. | ||||
| Description | If the merchant frontend does not give a "refund_delay" value upon creating a order, then no refund option should be offered for the item. | ||||
| Tags | No tags attached. | ||||
| Eh, offered by whom? Oh, and to clarify: it's OK if the /refund API is used in this case, it's just not _guaranteed_ that any refund will be possible because the exchange may then wire the funds virtually immediately to the merchant. So I'm not sure what change you expect is needed to the merchant here. Maybe the spec is still unclear? ;-) | |
| After clarifying this with Marcello: The merchant backend currently allows requests to /{orders}/refund even if giving a refund for this order doesn't make much sense, because the refund deadline is set to "0". Basically Marcello suggests to add a "sanity check" in the merchant that gives some error when the storefront tries POST /{orders}/refund for an order where we already know giving a refund doesn't make much sense. (Sure, it's possible that the exchange didn't wire the money yet ... but such a check by the backend might make sense to prevent the common error of forgetting to set the refund deadline. The current behavior just hides it between non-deterministic behavior.) | |
| Documented new 403 status code in 0212cfe..d356cbb | |
| Implemented in e2406406..7d81706c | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-09-10 17:52 | MS | New Issue | |
| 2020-09-10 17:52 | MS | Status | new => assigned |
| 2020-09-10 17:52 | MS | Assigned To | => MS |
| 2020-09-10 18:02 | Christian Grothoff | Note Added: 0016962 | |
| 2020-09-10 18:02 | Christian Grothoff | Note Edited: 0016962 | |
| 2020-09-11 11:16 | Florian Dold | Note Added: 0016963 | |
| 2020-09-11 20:54 | Christian Grothoff | Assigned To | MS => Christian Grothoff |
| 2020-10-07 10:45 | Christian Grothoff | Note Added: 0017000 | |
| 2020-10-07 10:47 | Christian Grothoff | Note Added: 0017001 | |
| 2020-10-07 10:47 | Christian Grothoff | Status | assigned => informing |
| 2020-10-07 10:47 | Christian Grothoff | Resolution | open => fixed |
| 2020-10-07 10:47 | Christian Grothoff | Fixed in Version | => 0.8 |
| 2020-10-07 10:47 | Christian Grothoff | Product Version | => git (master) |
| 2020-10-07 10:47 | Christian Grothoff | Target Version | => 0.8 |
| 2021-08-24 14:23 | Christian Grothoff | Status | informing => closed |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |