View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006588 | Taler | wallet-core | public | 2020-09-08 14:48 | 2026-11-02 19:55 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | informing | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0006588: wallet-core should support range queries for the transactions list | ||||
| Description | This might require some additional indices to be faster! | ||||
| Tags | No tags attached. | ||||
| related to | 0009030 | closed | Florian Dold | implement getTransactionsV2 API based on materialized transactions |
| related to | 0011912 | planning | iOS wallet should use range queries for the transactions list |
| Main thing to discuss here: How do we actually do the pagination? What do we use as the "cursor"? A transaction ID is not sufficient, as it doesn't efficiently allow querying transactions before or after it. So maybe a timestamp? But what if timestamps are not unique? Probably the cursor should be a (timestamp, txid) tuple. | |
| Is even possible to have the same timestamp for two tx since there is no multithread in the wallet? | |
| We've decided on an API: getTransactions({ filterStates, limit}) -> { results, cursor } => Start a new paginated query getTransactions({ cursor, limit}) -> { results, cursor } => Get more results (cursor encodes filter as well) (where limit can be negative/positive to go back/forwards in history) | |
| IMHO we need three groups: • "done", which might be thousands of transactions over the years if the user doesn’t delete them. • "waiting" == dialog (the user needs to confirm) plus pending (the other party needs to confirm) • all others (expired, failed, aborted, aborting, suspended, suspended-aborting). Could be named "uncompleted" or "unsuccessful". The result (list of transactions) should be sorted chronologically (newest first). | |
| Transactions now have ordered metadata, stable cursors, paged v2 retrieval, and forward/backward range tests (notably commit 8027c7c74) | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-09-08 14:48 | Florian Dold | New Issue | |
| 2020-09-08 14:48 | Florian Dold | Status | new => assigned |
| 2020-09-08 14:48 | Florian Dold | Assigned To | => Florian Dold |
| 2020-09-10 16:45 | Florian Dold | Target Version | 0.8.1 => 0.8 |
| 2020-09-10 16:48 | Christian Grothoff | Target Version | 0.8 => 0.8.1 |
| 2020-09-11 20:57 | Christian Grothoff | Severity | minor => tweak |
| 2021-08-24 18:39 | Christian Grothoff | Target Version | => 0.8.5 |
| 2022-10-20 08:45 | Christian Grothoff | Target Version | 0.8.5 => 0.9 |
| 2022-10-20 09:21 | Christian Grothoff | Target Version | 0.9 => 0.9.1 |
| 2023-01-10 17:36 | Christian Grothoff | Target Version | 0.9.1 => 0.9.2 |
| 2023-01-31 21:06 | sebasjm | Assigned To | Florian Dold => sebasjm |
| 2023-02-17 16:51 | Florian Dold | Target Version | 0.9.2 => 0.9.3 |
| 2023-04-13 18:36 | Florian Dold | Category | wallet (TS core) => wallet-core |
| 2023-05-07 14:43 | Florian Dold | Note Added: 0020188 | |
| 2023-06-06 17:53 | sebasjm | Note Added: 0020271 | |
| 2023-06-21 16:23 | Florian Dold | Target Version | 0.9.3 => 0.9.4 |
| 2023-06-21 16:26 | Florian Dold | Note Added: 0020299 | |
| 2023-09-04 17:42 | MarcS | Note Added: 0020490 | |
| 2023-09-23 13:52 | Christian Grothoff | Target Version | 0.9.4 => 0.10 |
| 2023-12-22 13:04 | Christian Grothoff | Severity | tweak => feature |
| 2023-12-22 13:04 | Christian Grothoff | Target Version | 0.10 => post-1.0 |
| 2024-08-02 07:10 | MarcS | Relationship added | related to 0009030 |
| 2025-04-17 21:53 | Christian Grothoff | Assigned To | sebasjm => |
| 2025-04-17 21:53 | Christian Grothoff | Status | assigned => implementing |
| 2026-08-27 06:59 | Florian Dold | Assigned To | => Florian Dold |
| 2026-08-27 06:59 | Florian Dold | Status | implementing => informing |
| 2026-08-27 06:59 | Florian Dold | Resolution | open => fixed |
| 2026-08-27 06:59 | Florian Dold | Note Added: 0029605 | |
| 2026-09-19 14:40 | Christian Grothoff | Fixed in Version | => 1.6 |
| 2026-09-19 14:44 | Christian Grothoff | Target Version | post-1.0 => 1.6 |
| 2026-11-02 19:55 | MarcS | Relationship added | related to 0011912 |