View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006520 | Taler | other | public | 2020-08-24 06:15 | 2023-01-26 21:53 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | low | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.9.1 | Fixed in Version | 0.9.1 | ||
| Summary | 0006520: GANA doesn't complain when error names are re-used with a new code, but it results in a compilation error | ||||
| Description | GANA should try to only generate headers that actually compile! When we repeat the name of an error code, only the C/TS/etc. compiler will catch this, but not the "make" inside the GANA repo that generates these files via templating. | ||||
| Tags | No tags attached. | ||||
| Eh, I tested, and GANA does complain properly *if* you run 'make check'. | |
| And 'check' is part of 'make all', so I'm not sure what you did to NOT get this error: $ make check recfix --check registry.rec registry.rec:125: error: %constraint[0] violated in record make: *** [Makefile:9: check] Error 1 [after manually introducing a problem as described] | |
| I've committed a broken registry here, to a branch: https://git.gnunet.org/gana.git/commit/?h=dev/dold/broken-registry&id=57ea691b13f689e29d66192c7c22cc2b41349e6c For me, this happens: $ cd gnu-taler-error-codes $ make check recfix --check registry.rec (exits with status 0) Here's my recutils version: $ recfix --version recfix (GNU recutils) 1.8.90 | |
| C'est bizzare! I tested with duplicate NAMEs just like you did, and 'make check' hated me as it should. But with your change, it is indeed breaking. | |
| Contacted jemarch via IRC, let's see what he says. | |
| jemarch says this is not supported. Maybe we'll get a feature update in the future ;-). | |
| jemarch has now implemented this with the new singular annotation. Alas, the latest recutils still needs to be broadly available... | |
| Fix committed to master branch. | |
| 17b05a0..d83d258 adds the singular constraint. Should fix this for recently enough recutils versions. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-08-24 06:15 | Florian Dold | New Issue | |
| 2020-08-24 11:06 | Christian Grothoff | Note Added: 0016735 | |
| 2020-08-24 11:07 | Christian Grothoff | Note Added: 0016736 | |
| 2020-08-24 11:08 | Christian Grothoff | Assigned To | => Florian Dold |
| 2020-08-24 11:08 | Christian Grothoff | Status | new => feedback |
| 2020-08-24 12:05 | Florian Dold | Note Added: 0016737 | |
| 2020-08-24 12:10 | Christian Grothoff | Note Added: 0016738 | |
| 2020-08-24 12:11 | Christian Grothoff | Note Added: 0016739 | |
| 2020-08-24 12:54 | Christian Grothoff | Note Added: 0016745 | |
| 2020-08-24 12:55 | Christian Grothoff | Assigned To | Florian Dold => |
| 2020-08-24 12:55 | Christian Grothoff | Priority | normal => low |
| 2020-08-24 12:55 | Christian Grothoff | Severity | minor => feature |
| 2020-08-24 12:55 | Christian Grothoff | Reproducibility | have not tried => always |
| 2020-08-24 12:55 | Christian Grothoff | Status | feedback => acknowledged |
| 2020-08-24 12:55 | Christian Grothoff | Product Version | => git (master) |
| 2022-06-28 12:29 | Christian Grothoff | Note Added: 0018946 | |
| 2022-11-08 14:08 | Christian Grothoff | ||
| 2022-11-08 14:08 | Christian Grothoff | Note Added: 0019394 | |
| 2022-11-08 14:08 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2022-11-08 14:08 | Christian Grothoff | Status | acknowledged => informing |
| 2022-11-08 14:08 | Christian Grothoff | Resolution | open => fixed |
| 2022-11-08 14:09 | Christian Grothoff | Fixed in Version | => 0.9.1 |
| 2022-11-08 14:09 | Christian Grothoff | Note Added: 0019395 | |
| 2022-11-08 14:09 | Christian Grothoff | Target Version | => 0.9.1 |
| 2023-01-26 21:53 | Christian Grothoff | Status | informing => closed |