View Issue Details

IDProjectCategoryView StatusLast Update
0006478Talerexchangepublic2024-01-12 13:05
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006478: refund API fails to verify 409 and 412 error responses from exchange
DescriptionThe exchange provides proof of the conflict/failure, but the client currently just believes it without checking.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2020-08-12 18:19

manager   ~0016594

26f72f85..6256bdb1 implements the checks, but the logic is untested AND a possible bug found while implementing shows that another major code path is not tested as well. I put an abort() + FIXME to mark the so far untested code. So we need better tests here.

Christian Grothoff

2020-08-12 22:51

manager   ~0016595

6256bdb1..4e0b5104 adds the missing tests and fixes the discovered issues on the now covered paths.

Issue History

Date ModifiedUsernameFieldChange
2020-08-12 10:13Christian GrothoffNew Issue
2020-08-12 10:13Christian GrothoffStatusnew => assigned
2020-08-12 10:13Christian GrothoffAssigned To => Christian Grothoff
2020-08-12 18:19Christian GrothoffNote Added: 0016594
2020-08-12 22:51Christian GrothoffNote Added: 0016595
2020-08-12 22:51Christian GrothoffStatusassigned => informing
2020-08-12 22:51Christian GrothoffResolutionopen => fixed
2020-08-12 22:51Christian GrothoffFixed in Version => 0.8
2020-08-12 22:51Christian GrothoffTarget Version0.8.1 => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2024-01-12 13:05Christian GrothoffCategoryexchange API (C) => exchange