View Issue Details

IDProjectCategoryView StatusLast Update
0006477Talermerchant backendpublic2024-01-12 13:04
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.8Fixed in Version0.8 
Summary0006477: already_paid_fulfillment_url is required by the public version of /orders/{order_id}
DescriptionOnly the storefront can really use the already_paid_order_id.

For the /orders/{order_id} HTML page (which in turn is making the /orders/{order_id} JSON request), the already_paid_order_id is not useful, as it can't really do anything with it. Instead, the backend should return the fulfillment URL corresponding to the already paid order ID.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2020-08-12 15:13

manager   ~0016591

Well, the fulfillment URLs must be _identical_ for both orders, as that's how we detect that they are for the same product.
So we can simply return god->fulfillment_url, right?

I've changed the code accordingly in ab1a421..326d73d -- please confirm and I'll update the spec.

Note that you will _always_ have the fulfillment URL, you still need to check if already_paid_order_id exists to determine that you can just redirect there.

Florian Dold

2020-08-18 07:35

manager   ~0016644

(I think this was resolved in a mumble discussion, but I didn't close it earlier. The spec looks good to me.)

Issue History

Date ModifiedUsernameFieldChange
2020-08-11 19:12Florian DoldNew Issue
2020-08-11 19:12Florian DoldStatusnew => assigned
2020-08-11 19:12Florian DoldAssigned To => Christian Grothoff
2020-08-12 15:13Christian GrothoffNote Added: 0016591
2020-08-12 15:13Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2020-08-12 15:13Christian GrothoffStatusassigned => feedback
2020-08-18 07:35Florian DoldStatusfeedback => informing
2020-08-18 07:35Florian DoldResolutionopen => fixed
2020-08-18 07:35Florian DoldNote Added: 0016644
2020-09-11 20:24Christian GrothoffFixed in Version => 0.8
2020-09-11 20:24Christian GrothoffTarget Version => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2024-01-12 13:04Christian GrothoffCategorymerchant backend API (C) => mechant backend
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend