View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006470 | Taler | merchant backend | public | 2020-08-10 11:21 | 2024-01-12 13:04 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0006470: Merchant logs "Finished handling request ... with status 0" despite HTTP 200 response | ||||
| Description | Can be reproduced by running the API test case (test_merchant_api). | ||||
| Tags | No tags attached. | ||||
| The easiest way to get the http status codes seems to be storing it in TMH_HandlerContext and accessing it through con_cls in handle_mhd_completion_callback. As far as storing the status code in TMH_HandlerContext, I'll just write wrappers around TALER_MHD_reply_* that store the status codes. | |
| Yes, but the above log message is from MHD, and here 'status 0' means successful conclusion. MHD will even report this on non-200 error codes, and I think that's OK. Please don't wrap the logging. I think this is just fine, one just needs to be careful when reading the log report. | |
| Note: non-zero status are used here in case of timeout or network failures. | |
| 838e8bf..0a30c30 modifies the log message to make it more clear that the 0 is an MHD termination code and NOT an HTTP status. | |
| Fix committed to master branch. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-08-10 11:21 | Florian Dold | New Issue | |
| 2020-08-10 11:21 | Florian Dold | Status | new => assigned |
| 2020-08-10 11:21 | Florian Dold | Assigned To | => Marcello Stanisci |
| 2020-08-10 12:32 | Florian Dold | Assigned To | Marcello Stanisci => jonathanbuchanan |
| 2020-08-20 05:58 | jonathanbuchanan | Note Added: 0016669 | |
| 2020-08-22 11:59 | Christian Grothoff | Note Added: 0016699 | |
| 2020-08-22 11:59 | Christian Grothoff | Note Added: 0016700 | |
| 2020-08-22 12:02 | Christian Grothoff | Note Added: 0016701 | |
| 2020-08-22 12:02 | Christian Grothoff | Assigned To | jonathanbuchanan => Christian Grothoff |
| 2020-08-22 12:02 | Christian Grothoff | Status | assigned => informing |
| 2020-08-22 12:02 | Christian Grothoff | Resolution | open => fixed |
| 2020-08-22 12:02 | Christian Grothoff | Fixed in Version | => 0.8 |
| 2020-08-22 12:02 | Christian Grothoff | Product Version | => git (master) |
| 2020-08-22 12:02 | Christian Grothoff | Target Version | => 0.8 |
| 2021-08-24 14:23 | Christian Grothoff | Status | informing => closed |
| 2021-09-02 16:22 | Christian Grothoff | ||
| 2021-09-02 16:23 | Christian Grothoff | Note Added: 0018373 | |
| 2024-01-12 13:04 | Christian Grothoff | Category | merchant backend API (C) => mechant backend |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |