View Issue Details

IDProjectCategoryView StatusLast Update
0006438Talermerchant backendpublic2021-08-24 14:23
ReporterMS Assigned Tojonathanbuchanan Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006438: assert+abort instead of reporting error
DescriptionThe merchant backend ends with assert+abort instead of returning a descriptive
error response to the client.

This behavior has been observed while trying to PATCH a merchant instance using
a wrong currency.

Jul 24 11:15:12-294318 taler-merchant-httpd-32299(MP57Q1VREBRAVWJHTTTZNEXY5R) ERROR Assertion failed at amount.c:370. Aborting.
Jul 24 11:15:13-353462 taler-merchant-httpd-13047 INFO Starting taler-merchant-httpd
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

MS

2020-07-24 09:42

reporter   ~0016512

This issue also suggests that upon instance *creation* there is no check on the currency.

Christian Grothoff

2020-07-24 09:55

manager   ~0016514

Right, we should add such a check and 400 if the currency is 'bad'.

jonathanbuchanan

2020-08-14 06:45

reporter   ~0016599

Check added in 968b356..5e9a041.

Issue History

Date ModifiedUsernameFieldChange
2020-07-24 09:37MSNew Issue
2020-07-24 09:37MSStatusnew => assigned
2020-07-24 09:37MSAssigned To => Marcello Stanisci
2020-07-24 09:42MSNote Added: 0016512
2020-07-24 09:54Christian GrothoffAssigned ToMarcello Stanisci => jonathanbuchanan
2020-07-24 09:55Christian GrothoffNote Added: 0016514
2020-07-24 09:55Christian GrothoffProduct Version => git (master)
2020-07-24 09:55Christian GrothoffTarget Version => 0.8
2020-08-14 06:45jonathanbuchananNote Added: 0016599
2020-08-15 00:12jonathanbuchananStatusassigned => informing
2020-08-15 00:12jonathanbuchananResolutionopen => fixed
2020-10-03 12:09Christian GrothoffFixed in Version => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend