View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006430 | Taler | merchant backend | public | 2020-07-16 16:38 | 2021-09-02 16:23 |
| Reporter | MS | Assigned To | jonathanbuchanan | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0006430: Responds with 404 for unclaimed orders. | ||||
| Description | The merchant responds with 404 when a unclaimed (existing!) order is requested via the GET /private/orders/$ID API. It needs to be fixed to return a object that informs the requester about the status of the order (as the documentation also suggests). Merchant test cases got also extended to reproduce this problem. | ||||
| Steps To Reproduce | Run: test_merchant_api | ||||
| Tags | No tags attached. | ||||
| Just to clarify: this implies looking in the 'orders' table and not only in the 'contracts' table. I thought we implemented this, but maybe not. To be verified. | |
| On my list, but Jonathan: if you get to it first, also great ;-). | |
| I'll work on this. Looks pretty easy to fix on the backend side, but the backend adds some fields to the contract_terms json, so the testing library will have to correctly add all those so we can generate the correct hash for when we look up the order. | |
| Actually, in this case you MUST NOT generate a contract hash, as for unclaimed orders such a contract hash is meaningless. So the response in this case must be without a contract hash. (That's why we use the term 'order': an order cannot have a contract hash, but a contract has one!). A payment begins with an order, and once claimed we have the contract terms and the hash. | |
| Oops. I was looking at the wallet code instead of the merchant code. | |
| fixed in 90adbb3..6c04f55. | |
| Fix committed to master branch. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-07-16 16:38 | MS | New Issue | |
| 2020-07-16 16:38 | MS | Status | new => assigned |
| 2020-07-16 16:38 | MS | Assigned To | => Marcello Stanisci |
| 2020-07-16 16:38 | MS | Assigned To | Marcello Stanisci => Christian Grothoff |
| 2020-07-16 17:34 | Christian Grothoff | Note Added: 0016471 | |
| 2020-07-16 17:35 | Christian Grothoff | Priority | normal => high |
| 2020-07-16 17:35 | Christian Grothoff | Severity | minor => major |
| 2020-07-16 17:35 | Christian Grothoff | Product Version | => git (master) |
| 2020-07-16 17:35 | Christian Grothoff | Target Version | => 0.8 |
| 2020-07-16 17:35 | Christian Grothoff | Note Added: 0016472 | |
| 2020-07-16 20:23 | jonathanbuchanan | Note Added: 0016480 | |
| 2020-07-16 20:57 | Christian Grothoff | Note Added: 0016481 | |
| 2020-07-16 21:07 | jonathanbuchanan | Note Added: 0016484 | |
| 2020-07-16 21:09 | jonathanbuchanan | Status | assigned => informing |
| 2020-07-16 21:09 | jonathanbuchanan | Resolution | open => fixed |
| 2020-07-16 21:09 | jonathanbuchanan | Note Added: 0016485 | |
| 2020-07-24 09:56 | Christian Grothoff | Fixed in Version | => 0.8 |
| 2021-08-24 14:23 | Christian Grothoff | Status | informing => closed |
| 2021-09-02 16:22 | jonathanbuchanan | ||
| 2021-09-02 16:23 | jonathanbuchanan | Note Added: 0018375 | |
| 2021-09-02 16:23 | jonathanbuchanan | Assigned To | Christian Grothoff => jonathanbuchanan |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |