View Issue Details

IDProjectCategoryView StatusLast Update
0006213Talerexchangepublic2021-09-02 16:14
Reporteroec Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.7.1Fixed in Version0.7.1 
Summary0006213: Better description of TALER_amount.fraction
DescriptionIn exchange/src/include/taler_amount_lib.h, TALER_amount is declared to have the following member:

 102 /**
 103 * Fraction (denominator of fraction)
 104 */
 105 uint32_t fraction;

I find "denominator" misleading. A value of 1 and a fraction of 2 is not an amount 1/2 but 1+2*TALER_AMOUNT_FRAC_BASE

I suggest to change the description to "Fraction (integer multiples of TALER_AMOUNT_FRAC_BASE)"
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2020-04-23 10:04

manager   ~0015756

Comment updated in 727eccbe..0774fd70, also gave the full formula with #TALER_AMOUNT_FRAC_BASE desciption.

Christian Grothoff

2021-09-02 16:14

manager   ~0018257

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2020-04-23 09:17oecNew Issue
2020-04-23 09:17oecStatusnew => assigned
2020-04-23 09:17oecAssigned To => Christian Grothoff
2020-04-23 10:04Christian GrothoffNote Added: 0015756
2020-04-23 10:04Christian GrothoffStatusassigned => informing
2020-04-23 10:04Christian GrothoffResolutionopen => fixed
2020-04-23 10:04Christian GrothoffFixed in Version => 0.7.1
2020-04-23 10:04Christian GrothoffProduct Version => git (master)
2020-04-23 10:04Christian GrothoffTarget Version => 0.7.1
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2021-09-02 16:13Christian Grothoff
2021-09-02 16:14Christian GrothoffNote Added: 0018257