View Issue Details

IDProjectCategoryView StatusLast Update
0006195Talerexchangepublic2021-09-02 16:14
Reporterfefe Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritymajorReproducibilityN/A
Status closedResolutionfixed 
Product Version0.7.0 
Target Version0.7.1Fixed in Version0.7.1 
Summary0006195: integer overflow in deserialize_denomination_key
DescriptionIn exchange/src/lib/exchange_api_refresh_common.c:

269 memcpy (&be,
270 buf,
271 sizeof (uint32_t));
272 pbuf_size = ntohl (be);
273 if (size < sizeof (uint32_t) + pbuf_size)

Not sure if you support 32-bit platforms, but on 32-bit the addition in line 273 can cause arithmetic overflow, leading to the range check not triggering and a potential out of bounds memory read (maybe even convertible into a Heartbleed situation):

279 dk->rsa_public_key
280 = GNUNET_CRYPTO_rsa_public_key_decode (&buf[sizeof (uint32_t)],
281 pbuf_size);

TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2020-04-21 13:30

manager   ~0015727

Fixed in 32bce6da..09294481

Christian Grothoff

2021-09-02 16:14

manager   ~0018259

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2020-04-21 13:22fefeNew Issue
2020-04-21 13:22fefeStatusnew => assigned
2020-04-21 13:22fefeAssigned To => Christian Grothoff
2020-04-21 13:30Christian GrothoffStatusassigned => informing
2020-04-21 13:30Christian GrothoffResolutionopen => fixed
2020-04-21 13:30Christian GrothoffFixed in Version => 0.7.1
2020-04-21 13:30Christian GrothoffNote Added: 0015727
2020-04-21 13:30Christian GrothoffTarget Version => 0.7.1
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2021-09-02 16:13Christian Grothoff
2021-09-02 16:14Christian GrothoffNote Added: 0018259