View Issue Details

IDProjectCategoryView StatusLast Update
0006086Talerbank API (C)public2020-03-31 14:04
Reportergrote Assigned Togrote Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.7.0Fixed in Version0.7.0 
Summary0006086: Provide bank API endpoint to get current account balance
DescriptionOne way of doing this could be to add some fields to the basic JSON response to include the beginning/ending balances around the history that is being returned.

For the cashier app, only the current balance is needed.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2020-02-10 22:49

manager   ~0015340

Last edited: 2020-02-10 22:49

I have proposed (but not implemented!) an API for this in a757d05..02507a8 (docs.git). Torsten: please let me know if the API is clear and will suffice in your opinion. Marcello/Florian: please make sure this is implementable for libeufin/Nexus.

grote

2020-02-10 23:15

reporter   ~0015343

Looking at this change, I would either choose the incoming or the outgoing history endpoint and then do (current_incoming - total_outgoing_end) or (total_incoming_end - current_outgoing) to calculate the current balance, right?

Unrelated to the issue at hand: The change doesn't make clear anymore that outgoing_transactions and incoming_transactions is an array.

Christian Grothoff

2020-02-11 21:25

manager   ~0015348

I fixed the array issue, but then Florian now convinced me that this is the 'wrong' place to do this. So most of my change will be reverted. We discussed that likely Marcello will write the 'right' API (ideally spec+implementation). Stay tuned...

grote

2020-03-06 16:57

reporter   ~0015434

This seems to have been implemented. Can we close this ticket?

Christian Grothoff

2020-03-06 20:23

manager   ~0015435

If it works for you, sure. Except 'resolve' is the right state until we made the release.

Issue History

Date ModifiedUsernameFieldChange
2020-02-10 18:41groteNew Issue
2020-02-10 18:41groteStatusnew => assigned
2020-02-10 18:41groteAssigned To => Christian Grothoff
2020-02-10 22:49Christian GrothoffNote Added: 0015340
2020-02-10 22:49Christian GrothoffAssigned ToChristian Grothoff => grote
2020-02-10 22:49Christian GrothoffStatusassigned => feedback
2020-02-10 22:49Christian GrothoffProduct Version => git (master)
2020-02-10 22:49Christian GrothoffTarget Version => 0.7.1
2020-02-10 22:49Christian GrothoffNote Edited: 0015340
2020-02-10 23:15groteNote Added: 0015343
2020-02-11 21:25Christian GrothoffNote Added: 0015348
2020-03-06 16:57groteNote Added: 0015434
2020-03-06 20:23Christian GrothoffNote Added: 0015435
2020-03-09 18:20groteStatusfeedback => informing
2020-03-09 18:20groteResolutionopen => fixed
2020-03-17 01:08Christian GrothoffFixed in Version => 0.7.0
2020-03-17 01:08Christian GrothoffTarget Version0.7.1 => 0.7.0
2020-03-31 14:04Christian GrothoffStatusinforming => closed