View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006039 | Taler | wallet-core | public | 2020-01-07 20:33 | 2026-09-19 14:45 |
| Reporter | Florian Dold | Assigned To | Resolution deadline | ||
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | won't fix | ||
| Product Version | git (master) | ||||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0006039: consider using underscores for the "public API" exposed by wallet-core | ||||
| Description | To make naming conventions consistent with other Taler JSON formats, we should consider moving to underscores in the history and pending operations. Historically the JSON generated by the wallet uses camelCase, since that's the most common convention for writing JavaScript code. Maybe we can take the route used by GSON (the JSON mapping library for Java (not JavaScript!)) and map to underscores only when (de-)serializing. | ||||
| Tags | No tags attached. | ||||
| Migration cost at this point is too high. Maybe later we can add some automated conversion like some Java JSON binding libraries do. | |
| This would only add churn, I don't see any reason to keep this one open. We'd likely have binary formats (CBOR etc.) before we change naming conventions. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-01-07 20:33 | Florian Dold | New Issue | |
| 2020-01-07 20:33 | Florian Dold | Assigned To | => Florian Dold |
| 2020-01-07 20:33 | Florian Dold | Status | new => assigned |
| 2020-08-20 06:03 | Florian Dold | Category | wallet (JS core) => wallet (TS core) |
| 2020-09-05 12:03 | Christian Grothoff | Severity | minor => tweak |
| 2020-09-05 12:03 | Christian Grothoff | Product Version | => git (master) |
| 2023-04-04 13:50 | Florian Dold | Target Version | => post-1.0 |
| 2023-04-04 13:51 | Florian Dold | Note Added: 0020009 | |
| 2023-04-13 18:36 | Florian Dold | Category | wallet (TS core) => wallet-core |
| 2023-08-24 14:23 | Florian Dold | Assigned To | Florian Dold => |
| 2023-08-24 14:23 | Florian Dold | Status | assigned => acknowledged |
| 2026-07-28 20:41 | Florian Dold | Status | acknowledged => closed |
| 2026-07-28 20:41 | Florian Dold | Resolution | open => won't fix |
| 2026-07-28 20:41 | Florian Dold | Note Added: 0029287 | |
| 2026-09-19 14:45 | Christian Grothoff | Fixed in Version | => 1.6 |
| 2026-09-19 14:45 | Christian Grothoff | Target Version | post-1.0 => 1.6 |