View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006025libmicrohttpdportabilitypublic2020-01-03 16:542021-09-02 15:54
Reporterrolegic Assigned ToChristian Grothoff Due Date
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
PlatformmacOSOSDarwinOS Version18.2.0
Product Version0.9.69 
Target Version0.9.70Fixed in Version0.9.70 
Summary0006025: Wrong #endif location
DescriptionFile src/microhttpd/daemon.c:
3284: {
3280 :#ifdef HAVE_MESSAGES
3281: MHD_DLOG (daemon,
3282: _ ("Failed to disable TCP Nagle on socket: %s\n"),
3283: MHD_socket_last_strerr_ ());
3284: }
3285: #endif

Closing parenthesis must be outside of preprocessing:

3284: #endif
3285: }
TagsNo tags attached.
Attached Files
daemon.c.patch (382 bytes)    
--- daemon.c	2019-10-31 13:06:06.000000000 +0100
+++ daemon_new.c	2020-01-03 17:48:11.101422400 +0100
@@ -3281,8 +3281,8 @@
     MHD_DLOG (daemon,
               _ ("Failed to disable TCP Nagle on socket: %s\n"),
               MHD_socket_last_strerr_ ());
-  }
 #endif
+  }
 #endif
 #if ! defined(USE_ACCEPT4) || ! defined(HAVE_SOCK_NONBLOCK)
   if (! MHD_socket_nonblocking_ (s))
daemon.c.patch (382 bytes)   

Activities

Christian Grothoff

2020-02-07 13:22

manager   ~0015313

Thanks for reporting, fixed in a2103adb..94e8d665

Christian Grothoff

2021-09-02 15:54

manager   ~0018172

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2020-01-03 16:54rolegicNew Issue
2020-01-03 16:54rolegicFile Added: daemon.c.patch
2020-02-07 13:17Christian GrothoffAssigned To => Christian Grothoff
2020-02-07 13:17Christian GrothoffStatusnew => assigned
2020-02-07 13:22Christian GrothoffStatusassigned => resolved
2020-02-07 13:22Christian GrothoffResolutionopen => fixed
2020-02-07 13:22Christian GrothoffFixed in Version => 0.9.70
2020-02-07 13:22Christian GrothoffNote Added: 0015313
2020-02-07 13:22Christian GrothoffTarget Version => 0.9.70
2020-02-08 21:03Christian GrothoffStatusresolved => closed
2021-09-02 15:54Christian Grothoff
2021-09-02 15:54Christian GrothoffNote Added: 0018172