View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006022 | Taler | wallet-core | public | 2019-12-31 12:50 | 2026-01-25 14:10 |
| Reporter | gmarcos87 | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.5 | ||||
| Summary | 0006022: I think I found a typo | ||||
| Description | While reviewing the HistoryEvents types I found an inconsistency in HistoryTipDeclinedEvent. The event type on line 165 of src/types/history.ts is HistoryEventType.TipAccepted instead of HistoryEventType.TipDeclined. Correcting that type results in an error in the src/operations/history.ts file on line 342, where tipAmount is defined instead of tipRaw. I don't know which part is wrong, if the definition of the type or its implementation. So I just upload this report. | ||||
| Tags | No tags attached. | ||||
| Thanks, this has been fixed in the following commit: https://git.taler.net/wallet-core.git/commit/?id=0842fab15482f155b967b4b100b0575bf44ce667 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-12-31 12:50 | gmarcos87 | New Issue | |
| 2019-12-31 12:50 | gmarcos87 | Tag Attached: Taler | |
| 2020-01-07 16:34 | Florian Dold | Assigned To | => Florian Dold |
| 2020-01-07 16:34 | Florian Dold | Status | new => assigned |
| 2020-01-07 16:35 | Florian Dold | Status | assigned => informing |
| 2020-01-07 16:35 | Florian Dold | Resolution | open => fixed |
| 2020-01-07 16:35 | Florian Dold | Note Added: 0015236 | |
| 2020-03-31 14:04 | Christian Grothoff | Status | informing => closed |
| 2020-08-20 06:03 | Florian Dold | Category | wallet (JS core) => wallet (TS core) |
| 2023-04-13 18:36 | Florian Dold | Category | wallet (TS core) => wallet-core |
| 2026-01-25 14:10 | Christian Grothoff | Tag Detached: Taler |