View Issue Details

IDProjectCategoryView StatusLast Update
0005930Talermerchant backendpublic2021-09-02 16:23
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0005930: control of instances over contract terms should be restricted
DescriptionCurrently, instance A can "pretend" to be instance B, by supplying the information of B in the contract terms.

Unless *explicitly* configured, an instance should not be able to set certain fields of the contract terms, such as the merchant field. This field should be taken from the instance configuration instead.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2020-04-13 19:32

manager   ~0015640

Is there a reason why you say this should be allowable by configuration? I'd simply 400 bad request such orders, unless you have a very good reason to allow it.

Christian Grothoff

2020-07-06 08:58

manager   ~0016387

Fixed in d37e16a..85a0221: require 'merchant' field to be provided by backend only.
We already force the merchant_pub being set by the backend.

Christian Grothoff

2021-09-02 16:23

manager   ~0018377

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2019-10-16 13:46Florian DoldNew Issue
2019-10-16 13:46Florian DoldStatusnew => assigned
2019-10-16 13:46Florian DoldAssigned To => Marcello Stanisci
2020-04-13 00:39Christian GrothoffAssigned ToMarcello Stanisci => Christian Grothoff
2020-04-13 19:32Christian GrothoffNote Added: 0015640
2020-04-13 19:33Christian GrothoffTarget Version0.7.1 => 0.8
2020-07-06 08:58Christian GrothoffNote Added: 0016387
2020-07-06 08:58Christian GrothoffStatusassigned => informing
2020-07-06 08:58Christian GrothoffResolutionopen => fixed
2020-07-06 08:58Christian GrothoffFixed in Version => 0.8
2021-08-24 14:23Christian GrothoffStatusinforming => closed
2021-09-02 16:22Christian Grothoff
2021-09-02 16:23Christian GrothoffNote Added: 0018377
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend