View Issue Details

IDProjectCategoryView StatusLast Update
0005887Talerexchangepublic2020-03-31 14:04
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.7.0Fixed in Version0.7.0 
Summary0005887: Order tests under bank-lib/
DescriptionThe codebase got bloated by a combination of tests, namely each test has multiple "flavours": "_with_fakebank", "_new", "_with_pybank", and possibly others. We should, first of all, discard the old-style tests (the ones not using libtalertesting), and then condensate all the logic in one source file that runs once against fakebank and once against pybank.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2019-09-10 22:54

reporter   ~0014882

Last edited: 2019-09-10 22:55

The condensation happened (ee6d7d75..e362c786), there is one file for non-twisted tests (test_bank_api_new.c) and one for twisted ones (test_bank_api_twisted.c). Now old tests need to be either discarded, or integrated into the new ones.

Marcello Stanisci

2020-01-09 12:15

reporter   ~0015259

test_bank_api_new.c *was* renamed as test_bank_api.c, therefore old tests got discarded; closing

Issue History

Date ModifiedUsernameFieldChange
2019-09-10 10:56Marcello StanisciNew Issue
2019-09-10 10:56Marcello StanisciStatusnew => assigned
2019-09-10 10:56Marcello StanisciAssigned To => Christian Grothoff
2019-09-10 10:57Marcello StanisciAssigned ToChristian Grothoff =>
2019-09-10 22:54Marcello StanisciNote Added: 0014882
2019-09-10 22:55Marcello StanisciNote Edited: 0014882
2019-09-16 07:26Christian GrothoffAssigned To => Marcello Stanisci
2020-01-09 12:15Marcello StanisciNote Added: 0015259
2020-01-09 12:15Marcello StanisciStatusassigned => informing
2020-01-09 12:15Marcello StanisciResolutionopen => fixed
2020-01-09 12:43Christian GrothoffProduct Version => git (master)
2020-01-09 12:43Christian GrothoffFixed in Version => 0.7.0
2020-01-09 12:43Christian GrothoffTarget Version => 0.7.0
2020-03-31 14:04Christian GrothoffStatusinforming => closed