View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005862 | Taler | other | public | 2019-08-30 14:08 | 2019-12-20 18:11 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005862: date format is weird and unnecessary | ||||
| Description | Parsing and creating it is annoying. There is no real reason for the weird stamp_expire: "/Date(123234)/" shenanigans. Either we shoud use a number, a string, or some actual JSON wrapper, like stamp_expire: { timestamp_sec: 1234 } which would be easier to parse and generate, and convey the same information with less weirdness. | ||||
| Tags | No tags attached. | ||||
| Hmm. I thought the current "/Date(X)/" had been created based on quite *extensive* discussions between us, with you basically pushing for exactly this format for various JS-related reasons (and other constraints). Addendum: [1] https://weblogs.asp.net/bleroy/dates-and-json was the original reasoning. Reasons why we don't just have a number is that it is unclear: is it a time?, also relative time vs. absolute time, and which unit (seconds, nanoseconds, etc.). Reasons to not use the nested JSON like timestamp_sec include it being even longer, and not really simplifying parsing. | |
| New date format has been implemented (in GNUnet util) and documented (https://docs.taler.net/core/api-common.html#timestamps). Some test cases in the merchant are still failing because of the change (see 0005997), but closing this one because that's mainly due to the inadequacy of these test cases. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-08-30 14:08 | Florian Dold | New Issue | |
| 2019-09-04 13:43 | Florian Dold | Description Updated | |
| 2019-09-04 13:52 | Florian Dold | Description Updated | |
| 2019-09-04 13:56 | Florian Dold | Description Updated | |
| 2019-09-06 00:12 | Christian Grothoff | Note Added: 0014868 | |
| 2019-09-06 00:12 | Christian Grothoff | Severity | minor => tweak |
| 2019-09-06 00:12 | Christian Grothoff | Status | new => feedback |
| 2019-09-16 07:14 | Christian Grothoff | Target Version | => 0.6 |
| 2019-09-16 07:17 | Christian Grothoff | Note Edited: 0014868 | |
| 2019-11-14 21:35 | Christian Grothoff | Target Version | 0.6 => 0.7.1 |
| 2019-11-29 12:04 | Christian Grothoff | Product Version | 0.6 => git (master) |
| 2019-11-29 12:04 | Christian Grothoff | Target Version | 0.7.1 => 0.6 |
| 2019-12-18 22:26 | Christian Grothoff | Assigned To | => Florian Dold |
| 2019-12-18 22:26 | Christian Grothoff | Status | feedback => assigned |
| 2019-12-20 01:27 | Florian Dold | Status | assigned => informing |
| 2019-12-20 01:27 | Florian Dold | Resolution | open => fixed |
| 2019-12-20 01:27 | Florian Dold | Note Added: 0015194 | |
| 2019-12-20 08:47 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-12-20 18:11 | Christian Grothoff | Status | informing => closed |