View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005851 | Taler | merchant backend | public | 2019-08-23 17:37 | 2024-01-12 13:04 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005851: /check-payment should support long polling and a 2nd, public endpoint | ||||
| Description | Ideally we'd be able to specify a timeout=... query parameter. The second public endpoint is necessary for JS in the browser to check if a mobile payment has happened. Unlike the private /check-payment, the public version must be provided with both the order ID as well as the contract hash, and the backend must validate the contract hash. This prevents enumeration of orders and their status when order IDs have low entropy. | ||||
| Tags | No tags attached. | ||||
| Florian, I'm not sure this bug note (still) properly describes the endpoint(s) we had discussed in the API spec. Could you please update the description (or link to spec) to make sure we are agreed on what should be done here? | |
| 44b5eaf..0d42e6b specifies a new /public/poll-payment endpoint. ae06bf1..ea48d9f implements this endpoint. C API and test cases are still missing. | |
| ea48d9f..3a22e60 implements the C API. | |
| Test command API added in e3db526..ce7ed80. Actual integration into a TEST is still missing. | |
| add8722..edfc078 fixes a few bugs and adds a now passing test for /public/poll-payment to the merchant. Bug resolved. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-08-23 17:37 | Florian Dold | New Issue | |
| 2019-08-23 17:37 | Florian Dold | Status | new => assigned |
| 2019-08-23 17:37 | Florian Dold | Assigned To | => Marcello Stanisci |
| 2019-09-16 07:41 | Christian Grothoff | Assigned To | Marcello Stanisci => Christian Grothoff |
| 2019-09-16 07:42 | Christian Grothoff | Severity | minor => feature |
| 2019-09-16 07:42 | Christian Grothoff | Product Version | => git (master) |
| 2019-09-16 07:42 | Christian Grothoff | Note Added: 0014903 | |
| 2019-09-16 07:42 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2019-09-16 07:42 | Christian Grothoff | Status | assigned => feedback |
| 2019-11-02 12:44 | Christian Grothoff | Note Added: 0015048 | |
| 2019-11-02 12:44 | Christian Grothoff | Assigned To | Florian Dold => Christian Grothoff |
| 2019-11-02 12:44 | Christian Grothoff | Status | feedback => assigned |
| 2019-11-02 13:34 | Christian Grothoff | Note Added: 0015049 | |
| 2019-11-02 13:34 | Christian Grothoff | Target Version | => 0.6 |
| 2019-11-02 23:01 | Christian Grothoff | Note Added: 0015051 | |
| 2019-11-07 21:04 | Christian Grothoff | Status | assigned => informing |
| 2019-11-07 21:04 | Christian Grothoff | Resolution | open => fixed |
| 2019-11-07 21:04 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-11-07 21:04 | Christian Grothoff | Note Added: 0015053 | |
| 2019-12-20 18:11 | Christian Grothoff | Status | informing => closed |
| 2024-01-12 13:04 | Christian Grothoff | Category | merchant backend API (C) => mechant backend |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |