View Issue Details

IDProjectCategoryView StatusLast Update
0005788Talerobsolete componentpublic2019-12-20 18:11
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritycrashReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.6Fixed in Version0.6 
Summary0005788: Malformed JSON on POST makes bank crash.
DescriptionPOSTing malformed JSONs to those endpoints that process authentication credentials
make bank terminate with unhandled exception.

  File "/home/marcello/prog/taler/bank/talerbank/app/views.py", line 621, in _decorator
    user_account = auth_and_login(request)
  File "/home/marcello/prog/taler/bank/talerbank/app/views.py", line 837, in auth_and_login
    data = json.loads(request.body.decode("utf-8"))
  File "/usr/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.7/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ':' delimiter: line 1 column 68 (char 67)
Steps To ReproducePOST malformed JSON (e.g.: {"a":1, "b"}) to any API call that takes login credentials.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0005787 closedMarcello Stanisci Make exception handling less confusing. 

Activities

Christian Grothoff

2019-09-16 07:50

manager   ~0014905

I guess given the relationship to 0005787, Marcello should fix this one after all ;-).

Marcello Stanisci

2019-11-16 02:15

reporter   ~0015077

bcb36f8..fd5b3e7 fixes this

Issue History

Date ModifiedUsernameFieldChange
2019-06-30 21:14Marcello StanisciNew Issue
2019-06-30 21:14Marcello StanisciStatusnew => assigned
2019-06-30 21:14Marcello StanisciAssigned To => Marcello Stanisci
2019-09-16 07:48Christian GrothoffSeverityminor => crash
2019-09-16 07:48Christian GrothoffProduct Version => git (master)
2019-09-16 07:48Christian GrothoffTarget Version => 0.6
2019-09-16 07:48Christian GrothoffAssigned ToMarcello Stanisci => Christian Grothoff
2019-09-16 07:49Christian GrothoffRelationship addedrelated to 0005787
2019-09-16 07:50Christian GrothoffNote Added: 0014905
2019-09-16 07:50Christian GrothoffAssigned ToChristian Grothoff => Marcello Stanisci
2019-11-16 02:15Marcello StanisciNote Added: 0015077
2019-11-16 02:15Marcello StanisciStatusassigned => informing
2019-11-16 02:15Marcello StanisciResolutionopen => fixed
2019-12-20 18:11Christian GrothoffFixed in Version => 0.6
2019-12-20 18:11Christian GrothoffStatusinforming => closed
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component