View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005715 | Taler | obsolete component | public | 2019-05-08 05:07 | 2019-12-20 18:12 |
| Reporter | Florian Dold | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005715: stop using validictory | ||||
| Description | We are using a library for input validation called "validictory" [1]. This library is ugly and also deprecated/unsupported. The way we're using this library is a complete mess [2]. Changing one parameter becomes and adventure of chasing down odd schema definitions. While there are much better python libraries available [3], why don't we just use Django's built-in form validation? That also works for GET parameters. [1] https://github.com/jamesturk/validictory [2] https://git.taler.net/bank.git/tree/talerbank/app/schemas.py?id=801d7032206cd89477bc201eccb5da47a5b975f2#n319 [3] https://valedictory.readthedocs.io/en/latest/ (sounds similar, but is completely different!) [4] https://pypi.org/project/jsonschema/ also kind of ugly, but at least based on a standard | ||||
| Tags | No tags attached. | ||||
| Purging Validictory from commit: c43180054aa94409. Next change should revise the way the exception middleware constructs error responses, but that's not strictly related to this one, therefore I am going to close here. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-05-08 05:07 | Florian Dold | New Issue | |
| 2019-05-08 05:07 | Florian Dold | Status | new => assigned |
| 2019-05-08 05:07 | Florian Dold | Assigned To | => Marcello Stanisci |
| 2019-05-31 18:31 | Marcello Stanisci | Note Added: 0014476 | |
| 2019-05-31 18:31 | Marcello Stanisci | Status | assigned => informing |
| 2019-05-31 18:31 | Marcello Stanisci | Resolution | open => fixed |
| 2019-06-01 08:57 | Christian Grothoff | Product Version | => git (master) |
| 2019-06-01 08:57 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-06-01 08:57 | Christian Grothoff | Target Version | => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |
| 2022-08-23 18:26 | Christian Grothoff | Category | bank (demonstrator) => py bank (demonstrator, obsolete) |
| 2023-12-03 00:23 | Christian Grothoff | Category | py bank (demonstrator, obsolete) => obsolete componet |
| 2023-12-11 19:08 | Florian Dold | Category | obsolete componet => obsolete component |