View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005704 | Taler | Web site(s) | public | 2019-04-26 18:21 | 2021-08-24 14:23 |
| Reporter | LUG | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0005704: Create common base template | ||||
| Description | To share the commonalities of all the demo pages (Introduction/Landing, Bank, Essay Shop, Donations, Tipping/Survey) a base template should be included in the web-common repo that all individual templates can inherit from. | ||||
| Tags | No tags attached. | ||||
| Development is happening in the branch feature/common-base-template of the repo web-common. | |
| Development is happening in the branch dev/lukas-grossberger/common-base-template in the relevant frontend repos. | |
| Would someone be so kind to have a look at my modifications to the "Makefile.am" in web-common's dev/lukas-grossberger/common-base-template? I'm completely new to makefiles and think I failed to adjust it to reflect the new directory structure with ccs/ js/ and template/ sub directories, because the hierarchical builds that create and trigger a makefile for web-common fail with errors like for landing: > make[3]: *** No rule to make target 'taler-wallet-lib.js', needed by 'all-am'. Stop. | |
| ng0 was right (on the mailinglist). I've shown you how to do this in 29c609f..c145e27 That said, with this change *all* configure.ac scripts that use the new structure must also be updated. Basically, you'll find at the bottom of the configure.ac a call to AC_OUTPUT([FOO BAR web-common/Makefile]). To that list, we now need to add "web-common/css/Makefile" and "web-common/js/Makefile". | |
| Thanks, Christian. I got it to work together with the matching feature branch in the landing repo. I'll follow that example in the other places as well. | |
| Progress notes: When trying to port flask powered repos like donations to the common template, "url( ... )" can't be used in templates but instead "url_for('static', filename=' ... ')" has to be used for static files. Next, try to figure out if "url_for" can be used everywhere, or whether there needs to / can be an alias for "url( ... )" in the jinja context that points to the static equivalent for the flask case. | |
| I'm excited to see Taler progress and regret not having pushed as much as I'd have liked so far. On my journey to achieve a common base template, a few repos have the common, responsive bootstrap template in the feature branch dev/lukas-grossberger/common-base-template. However, since I couldn't figure out a working local deployment of all Taler components, I wasn't able to update and test all relevant frontend repos to use the common base template. If someone feels like picking this up from the existing work, I'd be happy to hand it off. I'm not sure when I can put in more time to figure out the local dev setup. | |
| I think I started with this (not necessarily picking up what you had, but I might be wrong), but I'm looking into it again next week. | |
| No worries, I'm happy to hear that the demo frontend gets some additional love. If I can help bounce ideas, let me know. | |
| I just merged the landing.git into the taler-merchant-demos.git. This should substantially simply sharing style sheets, etc. Note that right now the HTML/CSS is still duplicated between the blog/donations/landing/survey sub-pages, but it should now be pretty easy to refactor this to eliminate the duplication. There is ALSO (some) duplication with the pybank (bank.git), but that uses a different tech stack and is not so easily avoided. | |
| Shared style sheets as of 193994e..46dd63a (within taler-merchant-demos, the pybank remains separate). | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-04-26 18:21 | LUG | New Issue | |
| 2019-04-26 18:22 | LUG | Note Added: 0014350 | |
| 2019-04-27 08:22 | LUG | Note Added: 0014354 | |
| 2019-04-27 13:23 | LUG | Note Added: 0014355 | |
| 2019-05-02 13:21 | Christian Grothoff | Note Added: 0014375 | |
| 2019-05-02 13:22 | Christian Grothoff | Assigned To | => LUG |
| 2019-05-02 13:22 | Christian Grothoff | Status | new => assigned |
| 2019-05-02 13:22 | Christian Grothoff | Severity | minor => tweak |
| 2019-05-02 13:22 | Christian Grothoff | Product Version | => git (master) |
| 2019-05-02 20:02 | LUG | Note Added: 0014378 | |
| 2019-06-10 12:36 | LUG | Note Added: 0014526 | |
| 2020-01-13 14:27 | LUG | Note Added: 0015263 | |
| 2020-01-14 09:02 | Christian Grothoff | Assigned To | LUG => nikita |
| 2020-04-25 13:55 | nikita | Note Added: 0015780 | |
| 2020-04-25 13:56 | nikita | Status | assigned => acknowledged |
| 2020-04-25 14:59 | LUG | Note Added: 0015782 | |
| 2020-05-05 07:53 | nikita | Assigned To | nikita => |
| 2020-10-11 19:07 | Christian Grothoff | Note Added: 0017009 | |
| 2020-10-11 19:07 | Christian Grothoff | Status | acknowledged => implementing |
| 2020-10-11 19:07 | Christian Grothoff | Target Version | => 0.8.1 |
| 2020-10-12 11:45 | Christian Grothoff | Note Added: 0017013 | |
| 2020-10-12 11:46 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2020-10-12 11:46 | Christian Grothoff | Status | implementing => informing |
| 2020-10-12 11:46 | Christian Grothoff | Resolution | open => fixed |
| 2020-10-12 11:46 | Christian Grothoff | Fixed in Version | => 0.8 |
| 2020-10-12 11:46 | Christian Grothoff | Target Version | 0.8.1 => 0.8 |
| 2021-08-24 14:23 | Christian Grothoff | Status | informing => closed |