View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005693 | Taler | Web site(s) | public | 2019-04-19 09:57 | 2019-12-20 18:12 |
| Reporter | LUG | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | block | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Linux x64 | OS | Ubuntu | OS Version | 16.04 |
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005693: Improve setup documentation for landing page repo | ||||
| Description | I tried following the instructions in landing/demo/README to locally setup the landing page repo for development and did not succeed (couldn't successfully execute make). I'd like to take this as an opportunity to improve the setup documentation for which I'd need some help to figure out how it is intended to work. One issues seems to be that it is not clear from which directory to run which of the setup commands (the location of the README or the repo root). Another seems to be some error in the way the make environment is constructed. I now phrased this issue in terms of an improvement. If that doesn't fit your conventions, please let me know or feel free to rename it accordingly. | ||||
| Steps To Reproduce | I'm on c05d4a7888e543bd5a17583a2e69fe3679567e75 and try to build the landing page as instructed by demo/README. Lines starting with $ indicate executed commands, other lines is the standard output resulting from these commands. $ cd /home/LUG/Workspace/taler_landing/demo/ $ git submodule init $ it submodule update --remote Submodule path 'static/web-common': checked out 'ba4a54c65786f35922616175b644f9db7897c87e' $ AUTOMAKE="automake --foreign" autoreconf -fiv autoreconf: 'configure.ac' or 'configure.in' is required $ cd .. $ AUTOMAKE="automake --foreign" autoreconf -fiv autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --force autoreconf: configure.ac: tracing autoreconf: configure.ac: not using Libtool autoreconf: running: /usr/bin/autoconf --force autoreconf: configure.ac: not using Autoheader autoreconf: running: automake --foreign --add-missing --copy --force-missing autoreconf: Leaving directory `.' $ ./configure checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking for tsc... no checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating demo/Makefile config.status: creating demo/static/Makefile config.status: creating demo/static/web-common/Makefile $ make make: *** No targets specified and no makefile found. Stop. $ cd demo $ make Making all in static make[1]: Entering directory '/home/LUG/Workspace/taler_landing/demo/static' Making all in web-common make[2]: Entering directory '/home/LUG/Workspace/taler_landing/demo/static/web-common' python3 -m jsmin taler-wallet-lib.js > taler-wallet-lib.min.js /home/LUG/anaconda3/bin/python3: No module named jsmin Makefile:456: recipe for target 'taler-wallet-lib.min.js' failed make[2]: *** [taler-wallet-lib.min.js] Error 1 make[2]: Leaving directory '/home/LUG/Workspace/taler_landing/demo/static/web-common' Makefile:295: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/home/LUG/Workspace/taler_landing/demo/static' Makefile:347: recipe for target 'all-recursive' failed make: *** [all-recursive] Error 1 | ||||
| Tags | No tags attached. | ||||
| I just saw 0005687 and the deployment/doc/onboarding.texi file, which also describes setting up the landing page repo. Would it make sense to remove move landing/demo/README to landing/README and just refer to the deployment repo for documentation if that is your central source of information regarding setup? | |
| c05d4a7..be527b1 moves the README to the top-level and modifies the build system so one can run 'make' from the top level. I also documented the dependencies, including python3-jsmin. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-04-19 09:57 | LUG | New Issue | |
| 2019-04-19 10:07 | LUG | Note Added: 0014302 | |
| 2019-04-20 13:02 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2019-04-20 13:02 | Christian Grothoff | Status | new => assigned |
| 2019-04-20 13:02 | Christian Grothoff | Product Version | => git (master) |
| 2019-04-20 13:02 | Christian Grothoff | Target Version | => 0.6 |
| 2019-04-20 20:33 | Christian Grothoff | Note Added: 0014323 | |
| 2019-04-20 20:33 | Christian Grothoff | Status | assigned => informing |
| 2019-04-20 20:33 | Christian Grothoff | Resolution | open => fixed |
| 2019-04-20 20:33 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |