0005685: test_exchangedb.c gnunet_memcmp refactoring question

ID	Project	Category	View Status	Date Submitted	Last Update
0005685	Taler	exchange	public	2019-04-08 18:11	2019-04-10 11:25

Reporter	nikita	Assigned To	Christian Grothoff	Resolution deadline
Implementer		Reviewer
Release signed by		Deployed by
Verifier		Communicator
Data protection authority notification required	No
CSIRT notification required	No
Estimated effort (hours)		Actual effort (hours)	0
Fast-track	No
Work package	none
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	0.5
Target Version	0.6	Fixed in Version	0.6

Summary	0005685: test_exchangedb.c gnunet_memcmp refactoring question
Description	In ./src/exchangedb/test_exchangedb.c, function check_refresh_reveal_cb, is it appropriate to replace the last memcmp with GNUNET_memcmp (in line ~440 (lines number might differ I have unpushed changed))? GNUNET_assert (0 == memcmp (tprivs, tprivsr, sizeof (struct TALER_TransferPrivateKeyP) * (TALER_CNC_KAPPA - 1))); tprivsr is const struct TALER_TransferPrivateKeyP, tprivs is static struct TALER_TransferPrivateKeyP.
Tags	No tags attached.

Date Modified	Username	Field	Change
2019-04-08 18:11	nikita	New Issue
2019-04-08 18:11	nikita	Status	new => assigned
2019-04-08 18:11	nikita	Assigned To	=> Christian Grothoff
2019-04-08 19:59	Christian Grothoff	Note Added: 0014277
2019-04-08 20:12	nikita	Note Added: 0014278
2019-04-10 11:24	Christian Grothoff	Status	assigned => closed
2019-04-10 11:24	Christian Grothoff	Resolution	open => fixed
2019-04-10 11:24	Christian Grothoff	Fixed in Version	=> 0.6
2019-04-10 11:25	Christian Grothoff	Product Version	=> 0.5
2019-04-10 11:25	Christian Grothoff	Target Version	=> 0.6

Christian Grothoff 2019-04-08 19:59 manager ~0014277	Yes, there the old memcmp has to stay, as we're comparing arrays.

nikita 2019-04-08 20:12 reporter ~0014278	Hm, I see.