View Issue Details

IDProjectCategoryView StatusLast Update
0005672Talerexchangepublic2019-12-20 18:12
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.6Fixed in Version0.6 
Summary0005672: Should "TALER_TESTING_cmd_check_keys()" relax the check on the number of denom keys?
DescriptionSometimes, the aforementioned command gets a number of keys that differs "slightly" from the expectation. This has been observed especially when very big "lookahead_sign" values are used in the configuration.

So *possibly*, with such big values we can't expect clocks to have a deterministic behaviour, and it *might* be better to relax the check of such testing command so that it expects from N-x to N+x keys (for whatever reasonable x value).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2019-03-29 10:24

reporter   ~0014239

Last edited: 2019-03-29 10:24

Right now, there is only one point in the code where this happens, and it got commented out. Look for "<sharp sign>5672" within the new "cherry picking" test case file.

Christian Grothoff

2019-03-30 21:30

manager   ~0014241

Yes, we probably should relax the check, or write a better check that looks more "deeply" into the /keys response.

Marcello Stanisci

2019-04-11 14:50

reporter   ~0014289

No need to relax the check after having added the option of passing the current time to the keying logic.

Issue History

Date ModifiedUsernameFieldChange
2019-03-29 10:17Marcello StanisciNew Issue
2019-03-29 10:17Marcello StanisciStatusnew => assigned
2019-03-29 10:17Marcello StanisciAssigned To => Christian Grothoff
2019-03-29 10:24Marcello StanisciNote Added: 0014239
2019-03-29 10:24Marcello StanisciNote Edited: 0014239
2019-03-30 21:29Christian GrothoffAssigned ToChristian Grothoff => Marcello Stanisci
2019-03-30 21:30Christian GrothoffNote Added: 0014241
2019-04-11 14:50Marcello StanisciNote Added: 0014289
2019-04-11 14:50Marcello StanisciStatusassigned => informing
2019-04-11 14:50Marcello StanisciResolutionopen => fixed
2019-04-20 10:06Christian GrothoffProduct Version => git (master)
2019-04-20 10:06Christian GrothoffFixed in Version => 0.6
2019-04-20 10:06Christian GrothoffTarget Version => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed