View Issue Details

IDProjectCategoryView StatusLast Update
0005666Talerobsolete componentpublic2019-12-20 18:12
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.6Fixed in Version0.6 
Summary0005666: bank and wire plugin should support date-based transaction histories
DescriptionSome banks do not support querying only the latest transaction after some other transaction. In fact, a transaction with an *earlier* date might be reported in a second transaction list query, which was not present in the first.

In practice, a banking API could give us a transaction that happened 5 days ago only today, even if we already got transactions confirmed from yesterday. Unfortunately we *need* to support this kind of awfully designed API, since that is what some banks offer.

In turn, both the bank and the wire plugin API (!!) should support this alternate interface, while *also* supporting the faster one based on monotonically increasing transaction numbers.

In summary, the bank and wire plugin must support querying for transactions based on a date range. The wire plugins also must ignore if duplicated transactions are reported.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2019-04-04 16:27

reporter   ~0014258

The Python Bank implements such date-based histories: 4a131f632f936eb49adb7f608851. Will leave this open until fakebank does the same.

Marcello Stanisci

2019-04-10 17:08

reporter   ~0014286

This commit: 5c496633092de5ebccd43e, adds the "/history-range" API to the fakebank + testing library.

Note that both the pybank and fakebank have tests for the new feature, but not "a lot". However, we'll have many occasions to test this API once the wirewatch will be able to speak to them, so I'm going to close this bug!

Issue History

Date ModifiedUsernameFieldChange
2019-03-22 19:18Florian DoldNew Issue
2019-03-22 19:18Florian DoldStatusnew => assigned
2019-03-22 19:18Florian DoldAssigned To => Marcello Stanisci
2019-04-04 16:27Marcello StanisciNote Added: 0014258
2019-04-10 17:08Marcello StanisciNote Added: 0014286
2019-04-10 17:08Marcello StanisciStatusassigned => informing
2019-04-10 17:08Marcello StanisciResolutionopen => fixed
2019-04-10 18:51Christian GrothoffProduct Version => git (master)
2019-04-10 18:51Christian GrothoffFixed in Version => 0.6
2019-04-10 18:51Christian GrothoffTarget Version => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component