View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005593 | Taler | obsolete component | public | 2019-02-20 16:55 | 2019-12-20 18:12 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005593: Need 404 page. | ||||
| Description | If a nonexistent page is tried to be accessed, the bank shows the Django's exception page. Instead, a custom "page not found" page should be displayed. | ||||
| Tags | No tags attached. | ||||
| This commit b0f9913, has all the gear in place but it's missing the last step to make the change effective: switching the "debug = True" line to "debug = False" in settings.py. So we should agree about this forthcoming switch before resolving this issue! | |
| Can we have debug on on test, and off on demo? | |
| Yes, but the only viable way that I can think of is putting some condition inside settings.py that sets debug to False if it is running on 'demo', or to True otherwise. Not sure if there is some way to "pinpoint" a commit for a particular file and make it stick to that commit. This way we could put "debug = False" for commit X at stable branch, and make settings.py stick to that commit for all its life (or until we change policy). In fact, settings.py changes very rarely so this would not impact very much our overall activity; but at the same time, it sounds very dirty. | |
| Testing for the hostname in settings.py sounds viable, but crazy Git hacks not so much. I think this is only worth it if we can keep it reasonably simple. Otherwise, just turn it off. | |
| Resolved with the check in settings.py, b0f9913..652e1f1. | |
| And by the way: we check for a env variable to be defined instead of parsing hostnames. This variable is defined as soon as one runs 'source activate' which must be done upon SSH'ing into the server. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-02-20 16:55 | Marcello Stanisci | New Issue | |
| 2019-02-20 16:55 | Marcello Stanisci | Status | new => assigned |
| 2019-02-20 16:55 | Marcello Stanisci | Assigned To | => Marcello Stanisci |
| 2019-02-20 17:35 | Marcello Stanisci | Note Added: 0013910 | |
| 2019-02-20 17:35 | Marcello Stanisci | Note Edited: 0013910 | |
| 2019-02-21 13:37 | Christian Grothoff | Note Added: 0013921 | |
| 2019-02-21 16:30 | Marcello Stanisci | Note Added: 0013924 | |
| 2019-02-21 16:59 | Christian Grothoff | Note Added: 0013925 | |
| 2019-02-21 17:00 | Christian Grothoff | Target Version | git (master) => |
| 2019-02-21 18:08 | Marcello Stanisci | Status | assigned => informing |
| 2019-02-21 18:08 | Marcello Stanisci | Resolution | open => fixed |
| 2019-02-21 18:08 | Marcello Stanisci | Note Added: 0013926 | |
| 2019-02-21 18:11 | Marcello Stanisci | Note Added: 0013927 | |
| 2019-02-27 20:11 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-02-27 20:11 | Christian Grothoff | Target Version | => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |
| 2022-08-23 18:26 | Christian Grothoff | Category | bank (demonstrator) => py bank (demonstrator, obsolete) |
| 2023-12-03 00:23 | Christian Grothoff | Category | py bank (demonstrator, obsolete) => obsolete componet |
| 2023-12-11 19:08 | Florian Dold | Category | obsolete componet => obsolete component |