View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005459 | Taler | exchange | public | 2018-10-15 10:10 | 2019-12-20 18:12 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005459: Change the way CMD structs are defined. | ||||
| Description | Every testing_api_cmd_*.c file should initialize their 'struct TALER_TESTING_Command' objects in the following way: TYPE cmd { .field1 = value; .field2 = value; }; This style enforces all those values not mentioned in the initialization to be created as 0/NULL. OTOH, the current style leave UNinitialized those fields that do not explicitly get a value. | ||||
| Additional Information | Although this bug targets the exchange, such changes should be carried on the merchant's, twister's (and possibly other?) codebases. | ||||
| Tags | No tags attached. | ||||
| You sure mean 'struct TALER_TESTING_Command'? There are also the various 'struct CommandXState' types; looks like they can also benefit from this change. | |
| Likely that other structs could also benefit. And I did write 'struct TALER_TESTING_Command', so I'm not sure what your question is. Example: testing_api_cmd_wire.c: struct TALER_TESTING_Command cmd; struct WireState *ws; ws = GNUNET_new (struct WireState); ws->exchange = exchange; ws->expected_method = expected_method; ws->expected_fee = expected_fee; ws->expected_response_code = expected_response_code; cmd.cls = ws; cmd.label = label; cmd.run = &wire_run; cmd.cleanup = &wire_cleanup; could be: struct TALER_TESTING_Command cmd = { .label = label, .run = &wire_run, .cleanup = &wire_cleanup }; struct WireState *ws; ws = GNUNET_new (struct WireState); ws->exchange = exchange; ws->expected_method = expected_method; ws->expected_fee = expected_fee; ws->expected_response_code = expected_response_code; cmd.cls = ws; return cmd; } | |
| Is it okay to put it the following way? I think it's better because you don't have to touch 'cmd' twice. struct WireState *ws; ws = GNUNET_new (struct WireState); ws->exchange = exchange; ws->expected_method = expected_method; ws->expected_fee = expected_fee; ws->expected_response_code = expected_response_code; struct TALER_TESTING_Command cmd = { .label = label, .run = &wire_run, .cleanup = &wire_cleanup, .cls = ws }; return cmd; | |
| Kind-of. If we want to be C89-compatible, you should start a new scope, i.e.: { // NEW! struct TALER_TESTING_Command cmd = { .label = label, .run = &wire_run, .cleanup = &wire_cleanup, .cls = ws }; return cmd; } // NEW! | |
| I did "my" (non-c89-compatible) way for now. The three codebases got it at the following commits: exchange: 9c82290a merchant: 6b184e2 twister: 396b774 I also could not (quickly) find any documentation about this c89 style. Let me know if I shall correct it to follow c89. | |
| Nah, we don't generally require c89 for GNUnet or Taler (only C99, where what you do is fine). Still, I do like scope minimization, but in this case I guess that might indeed be overkill. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-10-15 10:10 | Marcello Stanisci | New Issue | |
| 2018-10-15 10:10 | Marcello Stanisci | Status | new => assigned |
| 2018-10-15 10:10 | Marcello Stanisci | Assigned To | => Christian Grothoff |
| 2018-10-15 10:11 | Marcello Stanisci | Assigned To | Christian Grothoff => Marcello Stanisci |
| 2018-11-17 23:37 | Christian Grothoff | Severity | minor => tweak |
| 2018-11-17 23:37 | Christian Grothoff | Product Version | => git (master) |
| 2018-11-17 23:37 | Christian Grothoff | Target Version | => 0.8 |
| 2018-12-19 09:45 | Marcello Stanisci | Note Added: 0013420 | |
| 2018-12-19 09:50 | Christian Grothoff | Note Added: 0013421 | |
| 2018-12-19 10:00 | Marcello Stanisci | Note Added: 0013422 | |
| 2018-12-19 11:31 | Christian Grothoff | Note Added: 0013423 | |
| 2018-12-19 11:44 | Marcello Stanisci | Status | assigned => informing |
| 2018-12-19 11:44 | Marcello Stanisci | Resolution | open => fixed |
| 2018-12-19 11:44 | Marcello Stanisci | Note Added: 0013424 | |
| 2018-12-19 12:02 | Christian Grothoff | Note Added: 0013425 | |
| 2018-12-19 12:02 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2018-12-19 12:02 | Christian Grothoff | Target Version | 0.8 => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |