View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005449 | Taler | twister | public | 2018-09-29 12:16 | 2019-12-20 18:12 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005449: Make it compression-aware. | ||||
| Description | The Twister should be able to handle compressed payloads. Right now it just discards any compression header it gets from the client. | ||||
| Tags | No tags attached. | ||||
| Setting the HTTP header "Accept-Encoding: deflate" should do the trick. CURLOPT_ENCODING docs sugges that it will set that header, so at least in theory this should be the way to do this. | |
| Okay, but this (as far as I know) tells half of the story. In particular, after the twister gets the (supposedly) deflated content from the service, it is still not able to re-deflate it (via MHD) and return to the client. What now happens is that the twister returns the non-deflate content to the client but still sets the 'Content-Encoding: deflate' response header, hence making libgnunetcurl complain. So the question is: how does MHD behave? I grepped 'ACCEPT_ENCODING' and 'Accept-Encoding' through the whole source and I could not find any dedicated line.. This suggests that it ignores a client request for compressed data.. Is that correct? | |
| MHD does not process (or set) accept-encoding headers. If the application sets them, the application is responsible for compressing the body correctly. | |
| fb53910 implements this. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-09-29 12:16 | Marcello Stanisci | New Issue | |
| 2018-09-29 12:16 | Marcello Stanisci | Status | new => assigned |
| 2018-09-29 12:16 | Marcello Stanisci | Assigned To | => Marcello Stanisci |
| 2018-10-06 14:06 | Christian Grothoff | Note Added: 0013265 | |
| 2018-11-17 23:37 | Christian Grothoff | Severity | minor => tweak |
| 2018-11-17 23:37 | Christian Grothoff | Product Version | => git (master) |
| 2018-11-17 23:37 | Christian Grothoff | Target Version | => 0.8 |
| 2018-12-19 15:53 | Marcello Stanisci | Note Added: 0013426 | |
| 2018-12-19 17:14 | Christian Grothoff | Note Added: 0013427 | |
| 2018-12-20 18:59 | Marcello Stanisci | Status | assigned => informing |
| 2018-12-20 18:59 | Marcello Stanisci | Resolution | open => fixed |
| 2018-12-20 18:59 | Marcello Stanisci | Note Added: 0013428 | |
| 2018-12-20 20:36 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2018-12-20 20:36 | Christian Grothoff | Target Version | 0.8 => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |