View Issue Details

IDProjectCategoryView StatusLast Update
0005434Talerwallet (WebExtension)public2021-09-02 16:22
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.6Fixed in Version0.6 
Summary0005434: the exchange's /wire response should not include salt for accounts
DescriptionIt seems we're reusing the same structs for signing as we do for the merchant, which incidentally includes a salt (to increase entropy), which is unnecessary if the payto URI is public anyway.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2018-10-06 13:06

manager   ~0013263

Fixed in exchange in 81ce7abe..a56e2e34.
Related merchant updates in f2a5860..9dd7d3d.

Note that I did NOT update the wallet, and if the wallet checks /wire signatures, it should fail now (due to lack of salt). Thus assigning to Florian to ensure Wallet is updated as well.

Florian Dold

2019-12-05 22:21

manager   ~0015126

The wallet part for this has been fixed in 7b54439.

Christian Grothoff

2021-09-02 16:14

manager   ~0018281

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2018-09-19 09:35Florian DoldNew Issue
2018-09-19 09:35Florian DoldStatusnew => assigned
2018-09-19 09:35Florian DoldAssigned To => Christian Grothoff
2018-10-06 13:06Christian GrothoffNote Added: 0013263
2018-10-06 13:06Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2018-10-06 13:06Christian GrothoffCategoryexchange => wallet (WebExtensions)
2018-10-06 13:06Christian GrothoffSeverityminor => tweak
2018-11-17 23:39Christian GrothoffTarget Version => 0.6
2019-12-05 22:21Florian DoldStatusassigned => informing
2019-12-05 22:21Florian DoldResolutionopen => fixed
2019-12-05 22:21Florian DoldNote Added: 0015126
2019-12-20 18:11Christian GrothoffFixed in Version => 0.6
2019-12-20 18:11Christian GrothoffStatusinforming => closed
2021-09-02 16:13Christian Grothoff
2021-09-02 16:14Christian GrothoffNote Added: 0018281
2021-09-02 16:14Christian GrothoffAssigned ToFlorian Dold => Christian Grothoff
2021-09-02 16:22Christian Grothoff
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)