View Issue Details

IDProjectCategoryView StatusLast Update
0005383Talermerchant backendpublic2019-12-20 18:12
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.6Fixed in Version0.6 
Summary0005383: Integrity check on "total_amount" as of /track/transfer is missing.
DescriptionThe merchant does not check whether the "total_amount" field from /track/transfer response body actually matches the sum of all the coins involved in the wire transfer.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2018-07-26 13:06

reporter   ~0013150

This is not a bug, because this kind of check takes place within
the exchange-lib (used by the merchant to request /track/transfer).

However it emerged that the merchant logic aborted the execution if exchange-lib returned "424 Failed Dependency" upon a sloppy "total_amount" field, and so c993c0d fixed it (by simply passing the control to the proper callback).

Issue History

Date ModifiedUsernameFieldChange
2018-07-03 08:22Marcello StanisciNew Issue
2018-07-03 08:22Marcello StanisciStatusnew => assigned
2018-07-03 08:22Marcello StanisciAssigned To => Marcello Stanisci
2018-07-03 08:23Marcello StanisciTarget Version => 0.6
2018-07-03 08:23Marcello StanisciDescription Updated
2018-07-26 13:06Marcello StanisciNote Added: 0013150
2018-07-26 13:07Marcello StanisciStatusassigned => informing
2018-07-26 13:07Marcello StanisciResolutionopen => fixed
2018-09-15 09:06Christian GrothoffFixed in Version => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend