View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005307 | Taler | merchant backend | public | 2018-03-27 14:11 | 2019-12-20 18:12 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005307: list of merchant's uncovered code paths | ||||
| Description | The following (non-exhaustive) list contains paths of the merchant code that are not covered yet by the tests. * attempt to increase the refund on a contract that was not paid. * attempt to pickup a refund using a unknown order id * attempt to pickup a refund using a known order id from a non refunded contract * attempt to authorize a tip on a non-existent reserve. * attempt to pickup a tip using a non-existent tip_id. | ||||
| Tags | No tags attached. | ||||
| related to | 0005312 | closed | Marcello Stanisci | list of exchange operations we should test better |
| 0005313 includes "my" list based on coverage, which is in parts likely exactly the same. So if tests are added, we should update bug notes on both these bugs. | |
| The following issue should be addressed. May 22 09:10:02-146177 test-merchant-api-new-4401 DEBUG Running command `run-aggregator-11' May 22 09:10:02-164984 taler-exchange-aggregator-4517 ERROR Assertion failed at taler-exchange-aggregator.c:639 | |
| Commit 16d26b2 reaches the third point. | |
| 4th bullet point is not worth doing. It would require to stop and restart the merchant backend handing it a special artificial configuration file where the tipping instance is given a wrong reserve key. Sounds like lots of work for a not-so-critical issue. | |
| 7ada0ce implements the last point. | |
| @0012938: Reopening as it is actually possible to get a wrong reserve key without restarting the merchant. It suffices to just put a new instance in the configuration that points to a fake key. | |
| 9948929694bc74c9a tests the tip authorization over a wrong reserve key. | |
| At some point, it would be very convenient to have some coverage stats on the merchant *server* itself, not just the lib. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-03-27 14:11 | Marcello Stanisci | New Issue | |
| 2018-03-27 14:11 | Marcello Stanisci | Status | new => assigned |
| 2018-03-27 14:11 | Marcello Stanisci | Assigned To | => Marcello Stanisci |
| 2018-03-27 14:11 | Marcello Stanisci | Category | merchant backend API (C) => mechant backend |
| 2018-03-27 16:15 | Christian Grothoff | Product Version | => git (master) |
| 2018-03-27 16:15 | Christian Grothoff | Target Version | => 0.6 |
| 2018-03-27 16:15 | Christian Grothoff | Relationship added | related to 0005312 |
| 2018-03-27 16:16 | Christian Grothoff | Note Added: 0012910 | |
| 2018-05-22 07:13 | Marcello Stanisci | Note Added: 0012936 | |
| 2018-05-22 08:04 | Marcello Stanisci | Note Added: 0012937 | |
| 2018-05-22 08:42 | Marcello Stanisci | Note Added: 0012938 | |
| 2018-05-22 09:12 | Marcello Stanisci | Note Added: 0012939 | |
| 2018-05-22 09:12 | Marcello Stanisci | Status | assigned => informing |
| 2018-05-22 09:12 | Marcello Stanisci | Resolution | open => fixed |
| 2018-05-22 10:10 | Marcello Stanisci | Status | informing => new |
| 2018-05-22 10:10 | Marcello Stanisci | Resolution | fixed => reopened |
| 2018-05-22 10:10 | Marcello Stanisci | Note Added: 0012940 | |
| 2018-05-22 10:10 | Marcello Stanisci | Status | new => acknowledged |
| 2018-05-22 10:11 | Marcello Stanisci | Status | acknowledged => assigned |
| 2018-05-22 10:11 | Marcello Stanisci | Note Edited: 0012940 | |
| 2018-05-22 12:54 | Marcello Stanisci | Note Added: 0012949 | |
| 2018-05-22 12:55 | Marcello Stanisci | Status | assigned => informing |
| 2018-05-22 12:55 | Marcello Stanisci | Resolution | reopened => fixed |
| 2018-05-22 12:55 | Marcello Stanisci | Note Added: 0012951 | |
| 2018-06-12 07:00 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |