View Issue Details

IDProjectCategoryView StatusLast Update
0005283Talermerchant backendpublic2019-12-20 18:12
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.6Fixed in Version0.6 
Summary0005283: New test cases lack code comments.
DescriptionA big part of the "new styled" test instructions code needs comments.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2018-05-23 09:34

reporter   ~0012954

1f4f0f5 comments merchant tip CMDs.

Marcello Stanisci

2018-05-24 17:53

reporter   ~0012958

merchant testing lib header file and "traits" C files TBD.

Marcello Stanisci

2018-05-25 10:07

reporter   ~0012960

Last edited: 2018-05-25 10:08

This commits ends the merchant side: eb8549d94be9c36.

Libraries and header files are now commented; the test cases themselves
may lack verbose comments in a few places, but this is not so critical to
track here.

Leaving open to track the exchange side of it.

Marcello Stanisci

2018-05-28 15:26

reporter   ~0012964

7a1146f147da544 @exchange has comments for CMDs and
traits from the "lib" side. The _bank_-lib is still
lacking comments.

Once that part has been done, then the test suite themselves
would benefit from more commenting, although that is
not so critical to be kept tracked here.

Marcello Stanisci

2018-05-28 20:17

reporter   ~0012965

Last edited: 2018-05-28 20:18

Several trait offering functions - at the exchange AND the merchant - have the old 'selector' argument in the @param line; to be changed to the new 'index' paramenter.

Marcello Stanisci

2018-05-28 20:18

reporter   ~0012966

Ah, the exchange will also have to get the header files adapted to the new comments.

Marcello Stanisci

2018-05-29 10:19

reporter   ~0012967

3cb0454d comments exchange header files.

Marcello Stanisci

2018-05-29 10:45

reporter   ~0012968

01f933bb @ exchange and 3304bdb @ merchant address the "@param selector" problem, and close this issue.

Issue History

Date ModifiedUsernameFieldChange
2018-02-21 12:17Marcello StanisciNew Issue
2018-02-21 12:17Marcello StanisciStatusnew => assigned
2018-02-21 12:17Marcello StanisciAssigned To => Marcello Stanisci
2018-05-23 09:33Marcello StanisciTarget Version => 0.6
2018-05-23 09:34Marcello StanisciNote Added: 0012954
2018-05-24 17:53Marcello StanisciNote Added: 0012958
2018-05-25 10:07Marcello StanisciNote Added: 0012960
2018-05-25 10:08Marcello StanisciNote Edited: 0012960
2018-05-28 15:26Marcello StanisciNote Added: 0012964
2018-05-28 20:17Marcello StanisciNote Added: 0012965
2018-05-28 20:18Marcello StanisciNote Edited: 0012965
2018-05-28 20:18Marcello StanisciNote Added: 0012966
2018-05-29 10:19Marcello StanisciNote Added: 0012967
2018-05-29 10:45Marcello StanisciNote Added: 0012968
2018-05-29 10:46Marcello StanisciStatusassigned => informing
2018-05-29 10:46Marcello StanisciResolutionopen => fixed
2018-06-12 06:59Christian GrothoffProduct Version => git (master)
2018-06-12 06:59Christian GrothoffFixed in Version => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend