View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005282 | Taler | other | public | 2018-02-20 15:18 | 2021-08-24 14:23 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.8 | Fixed in Version | 0.8 | ||
| Summary | 0005282: style demo pages for better usability on mobile | ||||
| Description | Now that Firefox on Android can use the Taler wallet, we should make sure that the demo is less awkward to use on mobile. Currently the layout is not fit at all for smaller screens. | ||||
| Tags | No tags attached. | ||||
| I was trying to push changes addressing the mobile friendliness to feature/mobile-friendly but get the following git error: "fatal: remote error: access denied or repository not exported: /landing.git What's the contribution workflow here? | |
| For now, please attach patches to the bug report; if we find you're a consistent contributor, we'll give you the ability to push changes directly to our main Git. | |
| I'm giving this another try. @Florian, have you done something in that direction already that I should consider or do I start from the latest repo version? | |
| ack. Will work on this after GSoC. | |
| <code> <h2>Step 4: Check money flow</sup></h2> </code> is there any purpose for these seemingly misplaced sup tags I don't get immediately? | |
| I would just remove them, but there are too many of them to be random mistakes: ./demo/common/base.j2:81: <h2>Step 3: Pay</sup></h2> ./demo/common/base.j2:97: <h2>Step 4: Back office</sup></h2> ./demo/common/base.j2:113: <h2>Step 5: Reach out to us</sup></h2> ./demo/index.html.j2:84: <h2>Step 3: Pay</sup></h2> ./demo/index.html.j2:100: <h2>Step 4: Check money flow</sup></h2> ./demo/index.html.j2:112: <h2>Step 5: Merchant? Consult back-office</sup></h2> ./demo/index.html.j2:121: <h2>Step 6: Reach out to us</sup></h2> | |
| I have to ask because: > The HTML Superscript element (<sup>) specifies inline text which is to be displayed as superscript for solely typographical reasons. Superscripts are usually rendered with a raised baseline using smaller text. I assume it's leftover code unless you use this for something I have yet to find in the other code bases? | |
| sorry for the noise. 2 more git wrapper scripts later and finding 4767b306 in the repository: those are leftovers. | |
| It's very likely some left-over markup from copy&pasting the headings. It can definitely be removed. | |
| I've fixed the </sup> tags. | |
| I think the new style by Torsten is mobile-friendly, at least for my tests. Note that there is still a 404 issue with respect to test.taler.net and some CSS file. Still: closing this one. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-02-20 15:18 | Florian Dold | New Issue | |
| 2019-02-01 21:38 | LUG | Note Added: 0013556 | |
| 2019-02-02 09:49 | Christian Grothoff | Note Added: 0013557 | |
| 2019-04-26 18:18 | LUG | Note Added: 0014349 | |
| 2019-07-15 13:43 | nikita | Assigned To | => nikita |
| 2019-07-15 13:43 | nikita | Status | new => acknowledged |
| 2019-07-15 13:43 | nikita | Note Added: 0014675 | |
| 2019-09-04 18:12 | nikita | Note Added: 0014858 | |
| 2019-09-04 18:13 | nikita | Assigned To | nikita => Florian Dold |
| 2019-09-04 18:14 | nikita | Note Added: 0014859 | |
| 2019-09-04 18:20 | nikita | Note Added: 0014860 | |
| 2019-09-04 18:46 | nikita | Note Added: 0014861 | |
| 2019-09-04 18:46 | nikita | Assigned To | Florian Dold => nikita |
| 2019-09-05 14:39 | Florian Dold | Note Added: 0014866 | |
| 2019-09-06 10:31 | Florian Dold | Status | acknowledged => assigned |
| 2019-09-16 07:30 | Christian Grothoff | Severity | minor => tweak |
| 2020-05-05 07:54 | nikita | Assigned To | nikita => |
| 2020-05-05 09:05 | Christian Grothoff | Status | assigned => implementing |
| 2020-10-11 19:09 | Christian Grothoff | Note Added: 0017010 | |
| 2020-10-11 19:11 | Christian Grothoff | Note Added: 0017011 | |
| 2020-10-11 19:11 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2020-10-11 19:11 | Christian Grothoff | Status | implementing => informing |
| 2020-10-11 19:11 | Christian Grothoff | Resolution | open => fixed |
| 2020-10-11 19:11 | Christian Grothoff | Fixed in Version | => 0.8 |
| 2020-10-11 19:11 | Christian Grothoff | Product Version | => git (master) |
| 2020-10-11 19:11 | Christian Grothoff | Target Version | => 0.8 |
| 2021-08-24 14:23 | Christian Grothoff | Status | informing => closed |