View Issue Details

IDProjectCategoryView StatusLast Update
0005088Talertaler-merchant-demospublic2024-01-12 13:08
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.4Fixed in Version0.4 
Summary0005088: Implement refunds
DescriptionEvery fulfillment page must show a "refund" button that will trigger the refund logic.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2017-06-21 15:42

reporter   ~0012262

Last edited: 2017-06-22 09:03

(1) WARNING: on some transactions generated by the payment generator tool, it was possible to issue refunds bigger than the contract value.

(2) HINT: although payment generator has KUDOS:0.5 worth contracts, the deposit goes always for the coin value, which is ~KUDOS:5.0. At least, this
unblames the /refund logic

(3) SOLVED: the payment generator is "wrong": each coin's contribution to the contract's total amount is manually specified, and the math was simply wrong. Not a terrible bug though, we just voluntarily paid more! However, this was cause by me assuming that the TALER_MERCHANT_pay_wallet() would have done the math, as it takes the contract total amount among its parameters -- but then totally ignores it. So the question here is if we want to keep this parameter around...

Marcello Stanisci

2017-06-22 16:45

reporter   ~0012265

Finished in 46d89d1; available on 'test'.

Issue History

Date ModifiedUsernameFieldChange
2017-06-20 18:27Marcello StanisciNew Issue
2017-06-20 18:27Marcello StanisciAssigned To => Marcello Stanisci
2017-06-20 18:27Marcello StanisciStatusnew => assigned
2017-06-20 18:27Marcello StanisciTarget Version => 0.4
2017-06-21 15:42Marcello StanisciNote Added: 0012262
2017-06-21 16:31Marcello StanisciNote Edited: 0012262
2017-06-22 09:00Marcello StanisciNote Edited: 0012262
2017-06-22 09:03Marcello StanisciNote Edited: 0012262
2017-06-22 16:45Marcello StanisciStatusassigned => informing
2017-06-22 16:45Marcello StanisciResolutionopen => fixed
2017-06-22 16:45Marcello StanisciNote Added: 0012265
2017-06-29 10:17Christian GrothoffFixed in Version => 0.4
2017-10-18 13:42Christian GrothoffStatusinforming => closed
2024-01-12 13:08Christian GrothoffCategorymerchant frontend (blog) => Merchant frontends (Python3)
2026-08-23 14:16Florian DoldCategoryMerchant frontends (Python3) => taler-merchant-demos