View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005066 | Taler | merchant backend | public | 2017-06-05 16:25 | 2024-01-12 13:04 |
| Reporter | Christian Grothoff | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005066: /history API for merchant differs from /history for bank, and it is worse | ||||
| Description | Right now, /history for the merchant backend differs from the /bank API in several ways, all of which seem to make it inferior: 1) start/offset are "unsigned int", while the bank uses uint64_t. The later is not only more precise, but also 32 bits may simply not be enough. 4 billion transactions are totally within the range of large sites, so we need to use 64 bit values here (and BIGSERIAL in the backend DB). 2) 'delta' can only be positive; the possibility to pass 'GNUNET_YES' to 'find_contract_terms_by_date_and_range' is thus not possible with this API. However, it does make sense to have the same backwards-or-forwards navigation capabilities for the merchant /history than what we have for the bank /history. So 'delta' should become a int64_t. (Note that there is something with 'start' being not initialized and interpreted as -1 to go into the other direction implemented, but it seems more hack-ish than the bank /history version). 3) "unsigned int future" in 'find_contract_terms_by_date_and_range' should just be an 'int'. | ||||
| Tags | No tags attached. | ||||
| Just pointing out another divergence between the two APIs: the bank returns results YOUNGER than 'start' and the merchant returns results OLDER than 'start'. I think we should get them do the same thing (the bank's way). | |
| 2cce6fe addresses all the points reported in this issue. Just note that since the whole "delta" semantics has been inverted (in order to match the bank's), now 'future' got renamed as 'past' and has the desired type. | |
| Reopening as docs need to be updated, and possibly some additional minor changes could be needed. Also: the *backoffice* would need some attention after the change in the merchant /history API semantics. | |
| exchange / merchant / api have all been adapted as for recent (private) discussion (*): 15c1a877 / d52b2b0 / d6c5eaa. Leaving open until the backoffice gets some attention too. (*) long story short: okay to default 'start' to UINT64_MAX and okay to add a 'ordering' parameter that controls the way results are sorted. | |
| 317d1e5 made backoffice aligned with these API changes. Edit: 'start' defaults to *INT64_MAX* because Postgresql BIGSERIAL is a signed number type. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-06-05 16:25 | Christian Grothoff | New Issue | |
| 2017-06-05 16:25 | Christian Grothoff | Status | new => assigned |
| 2017-06-05 16:25 | Christian Grothoff | Assigned To | => Marcello Stanisci |
| 2017-06-05 16:47 | Christian Grothoff | Description Updated | |
| 2017-06-06 12:24 | Christian Grothoff | Target Version | 0.4 => 0.7.1 |
| 2018-12-13 15:11 | Marcello Stanisci | Note Added: 0013409 | |
| 2018-12-13 16:40 | Marcello Stanisci | Status | assigned => informing |
| 2018-12-13 16:40 | Marcello Stanisci | Resolution | open => fixed |
| 2018-12-13 16:40 | Marcello Stanisci | Note Added: 0013410 | |
| 2018-12-13 16:58 | Marcello Stanisci | Status | informing => assigned |
| 2018-12-13 16:58 | Marcello Stanisci | Note Added: 0013411 | |
| 2018-12-14 18:45 | Marcello Stanisci | Note Added: 0013414 | |
| 2018-12-17 17:04 | Marcello Stanisci | Note Added: 0013417 | |
| 2018-12-17 17:04 | Marcello Stanisci | Status | assigned => informing |
| 2019-01-31 18:33 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-01-31 18:33 | Christian Grothoff | Target Version | 0.7.1 => 0.6 |
| 2019-12-20 18:12 | Christian Grothoff | Status | informing => closed |
| 2024-01-12 13:04 | Christian Grothoff | Category | merchant backend API (C) => mechant backend |
| 2025-03-22 13:09 | Christian Grothoff | Category | mechant backend => merchant backend |