View Issue Details

IDProjectCategoryView StatusLast Update
0005059Talerwallet-corepublic2024-04-15 19:32
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.10Fixed in Version0.10 
Summary0005059: implement test case where an exchange's master public key changes [estimate: 5h]
DescriptionCurrently the wallet gets confused by this and may refuse some operations until you reset the wallet.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

has duplicate 0005775 closedFlorian Dold test weird corner cases regarding the exchange's /keys info 

Activities

Florian Dold

2021-06-15 17:05

manager   ~0017954

This is implemented now, but needs a test case.

Christian Grothoff

2023-09-03 13:21

manager   ~0020483

Bumping to 0.9.4, testcase is not RC.

Florian Dold

2023-11-09 15:00

manager   ~0020632

Last edited: 2023-11-09 15:12

It doesn't quite work right now, since the wallet isn't doing cache-breaking yet for /keys.

To do this, the query should be made with "Cache-Control: no-cache".

Florian Dold

2024-03-04 12:07

manager   ~0021632

Last edited: 2024-04-05 11:37

The test case should check that:
1. The wallet-core exchange entry correctly transitions to unavailable-update
2. Certain operations (withdrawals) are not accepted while in the unavailable-update state.
3. When the exchange is reset, it transitions back to an available state

Florian Dold

2024-04-05 11:30

manager   ~0022123

Test added and behavior fixed:

commit 7b2f95e482367183ca77f619d9ecbe34d5fd85bd (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Fri Apr 5 13:29:45 2024 +0200

    wallet-core: put exchange in update-unavailable if master pub / currency change unexpectedly

Issue History

Date ModifiedUsernameFieldChange
2017-06-04 15:47Florian DoldNew Issue
2017-06-04 15:47Florian DoldStatusnew => assigned
2017-06-04 15:47Florian DoldAssigned To => Florian Dold
2017-10-23 08:55Christian GrothoffProduct Version => git (master)
2017-10-23 08:55Christian GrothoffTarget Version => 0.6
2019-12-18 22:23Christian GrothoffTarget Version0.6 => 0.7.1
2020-08-29 12:04Christian GrothoffTarget Version0.7.1 => 0.8.1
2020-09-08 15:45Florian DoldCategorywallet (WebExtensions) => wallet (TS core)
2021-06-15 17:05Florian DoldNote Added: 0017954
2022-08-25 18:40Christian GrothoffRelationship addedhas duplicate 0005775
2023-02-19 23:44Florian DoldTarget Version => 0.9.4
2023-04-13 18:36Florian DoldCategorywallet (TS core) => wallet-core
2023-08-31 07:50Florian DoldTarget Version0.9.4 => 0.9.3
2023-09-03 13:21Christian GrothoffTarget Version0.9.3 => 0.9.4
2023-09-03 13:21Christian GrothoffNote Added: 0020483
2023-09-23 14:15Christian GrothoffTarget Version0.9.4 => 0.10
2023-11-09 15:00Florian DoldNote Added: 0020632
2023-11-09 15:12Florian DoldNote Edited: 0020632
2024-03-04 12:06Florian DoldSummaryhandle cases where an exchange's key changes, but the base URL stays the same => implement test case where an exchange's master public key changes
2024-03-04 12:07Florian DoldNote Added: 0021632
2024-03-27 20:15Florian DoldSummaryimplement test case where an exchange's master public key changes => implement test case where an exchange's master public key changes [estimate: 5h]
2024-04-05 10:02Florian DoldNote Edited: 0021632
2024-04-05 11:30Florian DoldStatusassigned => informing
2024-04-05 11:30Florian DoldResolutionopen => fixed
2024-04-05 11:30Florian DoldNote Added: 0022123
2024-04-05 11:37Florian DoldNote Edited: 0021632
2024-04-09 11:11Christian GrothoffFixed in Version => 0.10
2024-04-15 19:32Christian GrothoffStatusinforming => closed