0005022: amounts.py should define a class

ID	Project	Category	View Status	Date Submitted	Last Update
0005022	Taler	obsolete component	public	2017-05-22 12:45	2018-04-15 18:34

Reporter	Christian Grothoff	Assigned To	Marcello Stanisci	Resolution deadline
Implementer		Reviewer
Release signed by		Deployed by
Verifier		Communicator
Data protection authority notification required	No
CSIRT notification required	No
Estimated effort (hours)		Actual effort (hours)	0
Fast-track	No
Work package	none
Priority	high	Severity	tweak	Reproducibility	N/A
Status	closed	Resolution	fixed
Platform	i7	OS	Debian GNU/Linux	OS Version	squeeze
Product Version	git (master)
Target Version	0.5	Fixed in Version	0.5

Summary	0005022: amounts.py should define a class
Description	Right now, amounts in Python are simply represented as a 'dict'. It would seem cleaner to have a proper class "taler.amount" with three fields and methods to add/subtract/cmp/stringify/floatify, and constructors to parse (zero, CUR:val.frac). Also, the existing functions lack type annotations. Finally, the use of "settings.TALER_CURRENCY" should be avoided (get_zero) and instead the currency should be passed as an argument, as there may be multiple currencies used in the same application eventually, and the fundamental 'amount' abstraction should not depend on one currency being given in settings.
Tags	No tags attached.

Date Modified	Username	Field	Change
2017-05-22 12:45	Christian Grothoff	New Issue
2017-05-22 12:45	Christian Grothoff	Status	new => assigned
2017-05-22 12:45	Christian Grothoff	Assigned To	=> Marcello Stanisci
2017-05-22 12:45	Christian Grothoff	Summary	amounts.py should probably define a class => amounts.py should define a class
2017-10-23 08:25	Christian Grothoff	Priority	normal => high
2017-10-23 08:25	Christian Grothoff	Target Version	=> 0.5
2017-10-26 15:54	Marcello Stanisci	Note Added: 0012515
2017-10-26 16:41	Marcello Stanisci	Note Added: 0012516
2017-10-30 15:33	Marcello Stanisci	Status	assigned => informing
2017-10-30 15:33	Marcello Stanisci	Resolution	open => fixed
2017-10-30 15:33	Marcello Stanisci	Note Added: 0012527
2017-10-31 08:10	Christian Grothoff	Fixed in Version	=> 0.5
2018-04-15 18:34	Christian Grothoff	Status	informing => closed
2022-08-23 18:26	Christian Grothoff	Category	bank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23	Christian Grothoff	Category	py bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08	Florian Dold	Category	obsolete componet => obsolete component

Marcello Stanisci 2017-10-26 15:54 reporter ~0012515	such a class should never floatify any amount object: this operation does round numbers up, therefore making money disappear!

Marcello Stanisci 2017-10-26 16:41 reporter ~0012516	This class needs tests.

Marcello Stanisci 2017-10-30 15:33 reporter ~0012527	this feature was implemented at d0409b47b9fa from the 'copylib' repository. Manually copy the sources into any project where they are needed.