View Issue Details

IDProjectCategoryView StatusLast Update
0005019Talerobsolete componentpublic2020-09-04 23:45
ReporterChristian Grothoff Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionwon't fix 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0005019: taler bank should follow PEP 484 and 526 where applicable
DescriptionPEP 484 specifies a syntax for annotation arguments with types.

Wherever possible, we should add such type annotations.
Additional Informationhttps://www.python.org/dev/peps/pep-0484/
https://www.python.org/dev/peps/pep-0526/
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2017-05-22 12:40

manager   ~0012144

Once this approaches completion, the mypy tool should be integrated with the buildbot:

http://mypy-lang.org/

Marcello Stanisci

2017-12-06 16:55

reporter   ~0012628

arguments like '*args' and '**kwargs' will be type-annotated at last, as this requires special care.

Florian Dold

2020-09-04 11:09

manager   ~0016840

Resolving this as "won't fix", because there has been no meaningful progress with adding mypy annotations. For typed code, we should stick with TypeScript and Kotlin, or any other reasonable typed language.

I would say mypy is great for some very large and complex Python code bases, but for our small demo projects (and in conjunction with Django!), the costs of mypy don't justify the benefits.

Issue History

Date ModifiedUsernameFieldChange
2017-05-20 18:34Christian GrothoffNew Issue
2017-05-20 18:34Christian GrothoffStatusnew => assigned
2017-05-20 18:34Christian GrothoffAssigned To => Marcello Stanisci
2017-05-22 12:34Christian GrothoffSummarytaler bank should follow PEP 484 where applicable => taler bank should follow PEP 484 and 526 where applicable
2017-05-22 12:34Christian GrothoffAdditional Information Updated
2017-05-22 12:40Christian GrothoffNote Added: 0012144
2017-12-06 16:55Marcello StanisciNote Added: 0012628
2017-12-14 14:51Christian GrothoffTarget Version => 0.7.1
2020-03-29 20:08Christian GrothoffTarget Version0.7.1 => 0.8
2020-07-10 21:30Christian GrothoffTarget Version0.8 => 0.9
2020-07-24 10:08Christian GrothoffTarget Version0.9 => 0.9.1
2020-09-04 11:09Florian DoldStatusassigned => informing
2020-09-04 11:09Florian DoldResolutionopen => won't fix
2020-09-04 11:09Florian DoldNote Added: 0016840
2020-09-04 23:45Christian GrothoffStatusinforming => closed
2020-09-04 23:45Christian GrothoffFixed in Version => 0.8
2020-09-04 23:45Christian GrothoffTarget Version0.9.1 => 0.8
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component