View Issue Details

IDProjectCategoryView StatusLast Update
0005005Talerobsolete componentpublic2017-06-06 12:18
ReporterChristian Grothoff Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityurgentSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0005005: /admin/add/incoming should return serial ID of created record
DescriptionFor /history, we specify record selection by serial ID. For the testcases I am writing, I need to know the serial IDs chosen, and as postgres doesn't guarantee that they are sequential, I cannot guess them either. Not to mention it does generally make sense to return some UUID for the transaction from TALER_BANK_AdminAddIncomingResultCallback. I'm modifying libtalerbank accordingly, but the API and Python bank should be changed as well.

(Right now, 200 OK returns an empty response, so returning some proper success message is a good idea anyway, and "{serialid=NUMBER}" makes sense.)

Note also that you can get the serial ID using "INSERT ... RETURNING" in Postgres. See: https://www.postgresql.org/docs/current/static/sql-insert.html
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0004964 closedMarcello Stanisci bank needs API to query transaction history of user 

Activities

Christian Grothoff

2017-05-07 18:17

manager   ~0012113

Actually, also getting the execution date (timestamp) would be nice and should also be trivial.

Marcello Stanisci

2017-05-09 09:20

reporter   ~0012118

fixed in f97a7eb. Note that the object returned is {"row_id": x, "timestamp": "/Date(y)/"}. I decided for "row_id" as we use this in other parts of the bank's API.

Issue History

Date ModifiedUsernameFieldChange
2017-05-07 17:23Christian GrothoffNew Issue
2017-05-07 17:23Christian GrothoffStatusnew => assigned
2017-05-07 17:23Christian GrothoffAssigned To => Marcello Stanisci
2017-05-07 17:24Christian GrothoffRelationship addedrelated to 0004964
2017-05-07 18:17Christian GrothoffNote Added: 0012113
2017-05-07 19:17Christian GrothoffPrioritynormal => urgent
2017-05-09 09:20Marcello StanisciStatusassigned => informing
2017-05-09 09:20Marcello StanisciResolutionopen => fixed
2017-05-09 09:20Marcello StanisciNote Added: 0012118
2017-05-09 11:37Christian GrothoffFixed in Version => 0.3
2017-06-06 12:18Christian GrothoffStatusinforming => closed
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component