View Issue Details

IDProjectCategoryView StatusLast Update
0004999Talerotherpublic2017-06-06 12:18
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0004999: mitm loops on /keys
Descriptionwhenever the merchant tries to get /keys from an exchange proxied by the
MITM software layer, it keeps fetching /keys infinitely.
Steps To Reproduceexecute mitm.py located at src/mitm under the merchant repository,
make it point to a running exchange - by exporting the env variable
TALER_EXCHANGE_URL set to a running exchange's URL, and set the merchant
backend to use the mitm as the exchange.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2017-04-28 09:53

reporter   ~0012077

update about reproducing the issue: the mitm can now be executed by calling
the taler-merchant-mitm tool, passing the exchange's url to it.

See taler-merchant-mitm --help

Marcello Stanisci

2017-04-28 16:57

reporter   ~0012079

This *used* to happen because the mitm did not send back the "Expiration"
HTTP header to the merchant, so /keys' response appeared as expired, and the
download got retried.

This has been fixed by returning all the HTTP headers verbatim to the merchant.

The issue now is that the /keys' response gets "cut" at some point, so the JSON
is invalid.

Marcello Stanisci

2017-05-02 07:02

reporter   ~0012091

ee0fb92. Content-Length header used to "cut" the response making it invalid.

Issue History

Date ModifiedUsernameFieldChange
2017-04-27 14:09Marcello StanisciNew Issue
2017-04-27 14:10Marcello StanisciAssigned To => Marcello Stanisci
2017-04-27 14:10Marcello StanisciStatusnew => assigned
2017-04-28 09:53Marcello StanisciNote Added: 0012077
2017-04-28 16:57Marcello StanisciNote Added: 0012079
2017-05-02 07:02Marcello StanisciStatusassigned => informing
2017-05-02 07:02Marcello StanisciResolutionopen => fixed
2017-05-02 07:02Marcello StanisciNote Added: 0012091
2017-05-03 00:16Christian GrothoffFixed in Version => 0.3
2017-05-03 00:17Christian GrothoffTarget Version => 0.3
2017-05-04 22:02Christian GrothoffProduct Version => git (master)
2017-06-06 12:18Christian GrothoffStatusinforming => closed