View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004950 | Taler | wallet (WebExtension) | public | 2017-03-10 23:15 | 2020-07-16 21:01 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | text | Reproducibility | have not tried |
| Status | closed | Resolution | won't fix | ||
| Product Version | git (master) | ||||
| Target Version | 0.7.1 | Fixed in Version | 0.7.1 | ||
| Summary | 0004950: spec and implement asynchronous payment api | ||||
| Description | There should be a payment API for JavaScript heavy applications, where the page can make a payment request and the user has to confirm inside the extension popup. This has the benefit of being more resilient against click jacking. | ||||
| Tags | No tags attached. | ||||
| Since we can now query the status of a payment (instead of having cookies set on /pay), it is pretty easy to do payments from a Single Page App without destroying state by opening the payment_redirect_url in a new tab/window. We still might re-add a JS-based API for synchronous payments in the future, since: * it might provide nicer user experience than opening a tab/window by using browser-specific APIs (such as W3C payment handler/requests) * the developer experience might be nicer However in order to implement the latter part, the backend might have to expose APIs to the browser that right now only the frontend server has access to, such as querying the status of a payment (paid, not paid, refunded) based on an order id. It is probably not desirable to expose such an API to the public by default. Maybe the frontend can proxy these requests to the backend, but then we need to make sure we still have a nice API where we don't need to pass a slew of URLs around. | |
| IMHO we don't need an async payment API even for 1.0. Probably not ever. This bug was opened before we had the nice, HTTP-based wallet triggering. All potential use cases can be covered by just opening a new tab (or popup, window ...) that handles the payment. The argument against having such an API is that it makes detached wallets (i.e. on your mobile phone) a second-class citizen. We didn't even have mobile wallets when we opened this bug. As I don't even see us doing this post-1.0 (unless we get some really specific and reasonable use case), I would resolve this as "won't fix". | |
| Ok. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-03-10 23:15 | Florian Dold | New Issue | |
| 2017-03-14 11:03 | Christian Grothoff | Severity | minor => feature |
| 2017-03-14 11:04 | Christian Grothoff | Status | new => implementing |
| 2017-03-14 11:04 | Christian Grothoff | Category | other => wallet (browser-based) |
| 2017-03-14 11:04 | Christian Grothoff | Product Version | => git (master) |
| 2017-10-23 08:44 | Christian Grothoff | Assigned To | => Florian Dold |
| 2017-10-23 08:44 | Christian Grothoff | Severity | feature => text |
| 2017-10-23 08:44 | Christian Grothoff | Status | implementing => assigned |
| 2017-10-23 08:44 | Christian Grothoff | Target Version | => 0.7.1 |
| 2018-03-07 20:39 | Florian Dold | Note Added: 0012879 | |
| 2019-12-26 20:36 | Florian Dold | Category | wallet (browser-based) => wallet (WebExtensions) |
| 2020-07-16 17:58 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2020-07-16 17:58 | Florian Dold | Status | assigned => feedback |
| 2020-07-16 17:58 | Florian Dold | Note Added: 0016473 | |
| 2020-07-16 21:01 | Christian Grothoff | Status | feedback => informing |
| 2020-07-16 21:01 | Christian Grothoff | Resolution | open => won't fix |
| 2020-07-16 21:01 | Christian Grothoff | Fixed in Version | => 0.7.1 |
| 2020-07-16 21:01 | Christian Grothoff | Note Added: 0016483 | |
| 2020-07-16 21:01 | Christian Grothoff | Status | informing => closed |
| 2023-04-13 18:37 | Florian Dold | Category | wallet (WebExtensions) => wallet (WebExtension) |