View Issue Details

IDProjectCategoryView StatusLast Update
0004943Talermerchant backendpublic2017-10-18 13:42
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.4Fixed in Version0.4 
Summary0004943: backend does not store or verify wire transfer fee correctness
DescriptionRight now, the backend fails to store the wire transfer fees it obtained from the exchange during /pay, and then later does not check that the exchange didn't just charge a higher fee when it did the real wire transfer.

We should
1) store the wire fees (with exchange sig) in the DB
2) check that the exchange did not overcharge, and if not complain (in logs, and with error message to frontend)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2017-07-20 10:56

manager   ~0012360

Fees are now stored, and logic to retrieve fees exists and is tested.

Actual _checking_ still needs to be implemented.

Christian Grothoff

2017-07-23 12:31

manager   ~0012364

Fixed with Git 2d3fcf511582a69f4ee18a671b6cb2fba2dbdff6

Issue History

Date ModifiedUsernameFieldChange
2017-03-07 23:04Christian GrothoffNew Issue
2017-03-07 23:04Christian GrothoffStatusnew => assigned
2017-03-07 23:04Christian GrothoffAssigned To => Marcello Stanisci
2017-03-07 23:04Christian GrothoffAssigned ToMarcello Stanisci =>
2017-03-07 23:04Christian GrothoffStatusassigned => implementing
2017-03-08 12:15Christian GrothoffRelationship addedchild of 0004929
2017-03-18 22:27Christian GrothoffTarget Version => 0.7.1
2017-03-18 22:40Christian GrothoffAssigned To => Christian Grothoff
2017-03-18 22:40Christian GrothoffStatusimplementing => assigned
2017-03-19 05:54Christian GrothoffRelationship deletedchild of 0004929
2017-07-01 12:40Christian GrothoffTarget Version0.7.1 => 0.6
2017-07-20 10:56Christian GrothoffNote Added: 0012360
2017-07-23 12:31Christian GrothoffStatusassigned => informing
2017-07-23 12:31Christian GrothoffResolutionopen => fixed
2017-07-23 12:31Christian GrothoffFixed in Version => 0.4
2017-07-23 12:31Christian GrothoffNote Added: 0012364
2017-07-23 12:34Christian GrothoffTarget Version0.6 => 0.4
2017-10-18 13:42Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend