View Issue Details

IDProjectCategoryView StatusLast Update
0004935Talermerchant backendpublic2017-06-06 12:18
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0004935: check wire fees are acceptable or covered
DescriptionWe need to check that the wire fees charged by the exchange are acceptable to us, or covered by the customer.

This requires updating the contract specification with maximum wire fees, and us checking that the constraints are met.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0004936 closedFlorian Dold check wire fees are acceptable or covered when making payment 
child of 0004929 closedChristian Grothoff need to add wire transfer aggregate fee 

Activities

Christian Grothoff

2017-03-05 19:13

manager   ~0011893

As of 2b78ff4..09b01a1 the fee data is now parsed/processed and made available to /pay.

What is missing is that /pay needs to pass the wire transfer method to TMH_EXCHANGES_find_exchange(), and then use the fee information and payment data it is given to check that it is acceptable.

Christian Grothoff

2017-03-06 17:20

manager   ~0011898

Implemented in d3e568e..a4f578b

Issue History

Date ModifiedUsernameFieldChange
2017-03-04 15:55Christian GrothoffNew Issue
2017-03-04 15:55Christian GrothoffStatusnew => assigned
2017-03-04 15:55Christian GrothoffAssigned To => Marcello Stanisci
2017-03-04 15:55Christian GrothoffAssigned ToMarcello Stanisci => Christian Grothoff
2017-03-04 15:55Christian GrothoffRelationship addedchild of 0004929
2017-03-04 15:57Christian GrothoffRelationship addedrelated to 0004936
2017-03-05 19:13Christian GrothoffNote Added: 0011893
2017-03-06 17:20Christian GrothoffStatusassigned => informing
2017-03-06 17:20Christian GrothoffResolutionopen => fixed
2017-03-06 17:20Christian GrothoffFixed in Version => 0.3
2017-03-06 17:20Christian GrothoffNote Added: 0011898
2017-06-06 12:18Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend